Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix Naming of Files #122

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[core] Fix Naming of Files #122

merged 1 commit into from
Jan 31, 2024

Conversation

ricoberger
Copy link
Member

Fix the naming of some files: Instead of login we are always using the term sign in and already renamed the DesktopLoginManager to DesktopSignInManager in #106. During the renaming we forgot to rename the file which is now done.

We also renamed the sign_in_with_apple.dart file to signin_with_apple.dart, because the other files also do not contain an underscore between sign and in.

Fix the naming of some files: Instead of login we are always using the
term sign in and already renamed the `DesktopLoginManager` to
`DesktopSignInManager` in #106. During the renaming we forgot to rename
the file which is now done.

We also renamed the `sign_in_with_apple.dart` file to
`signin_with_apple.dart`, because the other files also do not contain an
underscore between sign and in.
@ricoberger ricoberger self-assigned this Jan 31, 2024
@ricoberger ricoberger added the changelog: changed Something was changed or updated label Jan 31, 2024
@ricoberger ricoberger added this to the v1.3.0 milestone Jan 31, 2024
@ricoberger ricoberger merged commit 04314f1 into main Jan 31, 2024
10 checks passed
@ricoberger ricoberger deleted the core-fix-naming-of-files branch January 31, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: changed Something was changed or updated
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant