Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Make Log Level Configurable #128

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

ricoberger
Copy link
Member

The log level is now configurable, via the FEEDDECK_LOG_LEVEL environment variable. The environment variable can have the following values: debug, info, warning or error.

With this change we also only log the response when getting and parsing the feed fails when the log level is set to debug, also when the actual message is still an error. This should reduce the noice in the logs a lot and allows us to specially turn this on while debugging.

@ricoberger ricoberger self-assigned this Feb 2, 2024
@ricoberger ricoberger added changelog: changed Something was changed or updated changelog: added A new feature was added and removed changelog: changed Something was changed or updated labels Feb 2, 2024
@ricoberger ricoberger added this to the v1.3.0 milestone Feb 2, 2024
The log level is now configurable, via the `FEEDDECK_LOG_LEVEL`
environment variable. The environment variable can have the following
values: `debug`, `info`, `warning` or `error`.

With this change we also only log the response when getting and parsing
the feed fails when the log level is set to `debug`, also when the
actual message is still an error. This should reduce the noice in the
logs a lot and allows us to specially turn this on while debugging.
@ricoberger ricoberger force-pushed the core-make-log-level-configurable branch from dc59c95 to 57e19c4 Compare February 2, 2024 15:26
@ricoberger ricoberger merged commit b8a73cc into main Feb 2, 2024
10 checks passed
@ricoberger ricoberger deleted the core-make-log-level-configurable branch February 2, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: added A new feature was added
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant