Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rss] Do Not Remove HTML Tags #129

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

ricoberger
Copy link
Member

We do not remove HTML tags from the description of a RSS feed item anymore, because:

  • This didn't worked for all feeds, because we first removed the tags and then unescape the data, which didn't make sense
  • We render the HTML to Makrdown in the frontend so that the description can contain HTML tags and is still properly rendered and in some case better rendered then before

@ricoberger ricoberger self-assigned this Feb 2, 2024
@ricoberger ricoberger added the changelog: changed Something was changed or updated label Feb 2, 2024
@ricoberger ricoberger added this to the v1.3.0 milestone Feb 2, 2024
We do not remove HTML tags from the description of a RSS feed item
anymore, because:

- This didn't worked for all feeds, because we first removed the tags
  and then unescape the data, which didn't make sense
- We render the HTML to Makrdown in the frontend so that the description
  can contain HTML tags and is still properly rendered and in some case
  better rendered then before
@ricoberger ricoberger merged commit c9a5961 into main Feb 2, 2024
10 checks passed
@ricoberger ricoberger deleted the rss-do-not-remove-html-tags branch February 2, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: changed Something was changed or updated
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant