[core] Fix Password Validations #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the password validations. In #130 we introduced some stronger password policies to forbid weak passwords, but forgot to change it in all places. Now the same rules are also applying when a user changes his password or resets his password. During the sign in we do not use the same rules, to not block users which have already signed up, with a password which doesn't match the rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the password validations. In #130 we introduced some stronger password policies to forbid weak passwords, but forgot to change it in all places. Now the same rules are also applying when a user changes his password or resets his password.
During the sign in we do not use the same rules, to not block users which have already signed up, with a password which doesn't match the rules.