[podcast] Stop Audio Playback on Windows and Linux #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows and Linux it could happen that the audio playback for a podcast wasn't stopped when the item details view for a podcast item was closed. This commit "fixes" the problem, by pausing the audio player, before the widget is disposed. This commit also fixes the condition when the background audio services should be initialized in the `main.dart` file. Instead of the macOS check, we checked for iOS twice.
ricoberger
deleted the
podcast-stop-audio-playback-on-windows-and-linux
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows and Linux it could happen that the audio playback for a podcast wasn't stopped when the item details view for a podcast item was closed.
This commit "fixes" the problem, by pausing the audio player, before the widget is disposed.
This commit also fixes the condition when the background audio services should be initialized in the
main.dartfile. Instead of the macOS check, we checked for iOS twice.