DataManger extensions #104
Conversation
wtrocki
requested review from
austincunningham,
JameelB,
paolobueno and
witmicko
as code owners
wtrocki
force-pushed
the
RAINCATCH-1126
branch
from
2ca6748
to
b569e5b
Compare
|
Changes Unknown when pulling b569e5b on wtrocki:RAINCATCH-1126 into ** on feedhenry-raincatcher:master**. |
| public stop(): Bluebird<any> { | ||
| const self = this; | ||
| return new Bluebird(function(resolve, reject) { | ||
| syncApi.startSync(self.datasetId, function() { |
| private getQueueSize = function() { | ||
| const self = this; | ||
| return new Bluebird(function(resolve) { | ||
| syncApi.getPending(self.datasetId, function(pending?) { |
There was a problem hiding this comment.
short form of pending?:any
There was a problem hiding this comment.
pending: any | undefined
There was a problem hiding this comment.
Is there a way to handle errors for this?
There was a problem hiding this comment.
Actually I was thinking about this as well and aparently this code is just fetching local data. Errors will just return empty object.
There was a problem hiding this comment.
👍 I thought that might be the case, maybe of an error value like -1 or so.
wtrocki
force-pushed
the
RAINCATCH-1126
branch
from
b569e5b
to
d5a53cf
Compare
|
Changes Unknown when pulling d5a53cf on wtrocki:RAINCATCH-1126 into ** on feedhenry-raincatcher:master**. |
| */ | ||
| public list(callback: (err?: Error, results?: any) => void) { | ||
| public list(): Bluebird<any> { |
There was a problem hiding this comment.
I think this could at least be an array type instead of bare any, helps client code a little.
There was a problem hiding this comment.
To be clear - you mean any[] ?
| resolve(dataSetData); | ||
| }, function handleSyncListError(syncErrorCode: string, syncErrorMessage: string) { | ||
| reject(new Error(self.formatSyncErrorMessage(syncErrorCode, syncErrorMessage))); | ||
| }); |
| Bluebird.resolve(); | ||
| }, function() { | ||
| Bluebird.reject(new Error('forceSync error')); | ||
| }); |
There was a problem hiding this comment.
I think this last then is redundant, and wrong since it's not returning anything.
If you're just looking to mask the return value and error value, .then(() => undefined).catch(() => Bluebird.reject(new Error('forceSync error'))) should do the trick.
wtrocki
force-pushed
the
RAINCATCH-1126
branch
from
fa59b10
to
21d84bc
Compare
|
Changes Unknown when pulling 21d84bc on wtrocki:RAINCATCH-1126 into ** on feedhenry-raincatcher:master**. |
Motivation
Implement forceSync in DataManagers for sync
See: feedhenry-raincatcher/raincatcher-angularjs#64 for mobile changes.