This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
RAINCATCH-1198 - sync mapper #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtrocki
requested review from
austincunningham,
JameelB,
paolobueno and
witmicko
as code owners
wtrocki
force-pushed
the
RAINCATCH-1198
branch
from
e30def8
to
5c6e785
Compare
Verification steps.
|
|
Changes Unknown when pulling e30def8 on wtrocki:RAINCATCH-1198 into ** on feedhenry-raincatcher:master**. |
|
Changes Unknown when pulling 5c6e785 on wtrocki:RAINCATCH-1198 into ** on feedhenry-raincatcher:master**. |
paolobueno
reviewed
Aug 31, 2017
cloud/datasync/README.md
Outdated
| ## Overriding sync filter on server | ||
|
|
||
| By default sync clients can specify any type of filter and efectivelly get access to | ||
| every record for dataset. If you wish to disable user query_filters for certain datasets for security reasons `SyncMapperMiddleware` should be used, before mounting sync express router. |
There was a problem hiding this comment.
I think this text implies that the mapper middleware is more flexible that just the user data, also the export's name is userMapperMiddleware, the SyncMapperMiddleware's filename won't be visible outside the module.
|
Changes Unknown when pulling d5df9b0 on wtrocki:RAINCATCH-1198 into ** on feedhenry-raincatcher:master**. |
paolobueno
approved these changes
Aug 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow to override query filter on server for security reasons.
Typical usage for filter will be to list results per specific user and do not allow any other filters for security reasons. This fix adds flexible way to do it.
Progress