This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
[RAINCATCH-623] Use fh-sync clearCache on logout #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtrocki
previously approved these changes
Sep 14, 2017
| @@ -138,9 +138,9 @@ export class DataManager { | |||
| const self = this; | |||
| return new Bluebird(function(resolve, reject) { | |||
| syncApi.stopSync(self.datasetId, function() { | |||
| resolve(); | |||
| return resolve(); | |||
There was a problem hiding this comment.
Btw.. thats optional and has no effect.
| @@ -179,8 +179,7 @@ export class DataManager { | |||
| const options = _.defaults(userOptions, defaultOptions); | |||
| function forceSyncThenStop(pendingUpdateQueueSize) { | |||
| if (pendingUpdateQueueSize === 0) { | |||
| self.stop().then(Bluebird.resolve); | |||
| return; | |||
| return self.stop().then(Bluebird.resolve); | |||
| } | |||
There was a problem hiding this comment.
I know its not your change but worth improving: then is not needed
There was a problem hiding this comment.
btw the cleanest way to wrap a promise in a bluebird one is return Bluebird.resolve(promisefn())
| * Clears the cache for the dataset | ||
| */ | ||
| public clearCache() { | ||
| const self = this; |
|
Changes Unknown when pulling 51d52ea on JameelB:RAINCATCH-623 into ** on feedhenry-raincatcher:master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the mobile app, the previous logged in user's data is shown upon login. We need to clear sync cache to prevent this.
Description
Utilize fh-sync's clearCache function to allow cache to be cleared upon logout.
Progress
Additional Notes
Related JIRA - https://issues.jboss.org/browse/RAINCATCH-623