This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
[RAINCATCH-1276] Update documentation and example to include JWT strategy #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JameelB We will need to review existing passport docs to include that as well. |
wtrocki
reviewed
Oct 2, 2017
cloud/passportauth/README.md
Outdated
| @@ -19,19 +18,42 @@ const authService: PassportAuth = new PassportAuth(userRepo, userService); | |||
| authService.init(router, sessionOptions); | |||
| or | |||
| authService.init(router, undefined, secret); | |||
|
|
|||
| ... | |||
| ``` | |||
| In order to use cookie-based authentication, specify the sessionOptions. | |||
| - For more information about the available express session options, see [express-session](https://github.com/expressjs/session). | |||
|
|
|||
| Without the sessionOptions, Passport will use token-based authentication using Passport's JWT strategy by default. | |||
There was a problem hiding this comment.
When sessionOptions argument will not be passed/skipped/undefined
wtrocki
reviewed
Oct 2, 2017
| @@ -31,8 +31,12 @@ export class SampleUserService implements UserService { | |||
| return user.password === password; | |||
| } | |||
|
|
|||
| public hasResourceRole(user: any, role: string) { | |||
| return user.roles.indexOf(role) > -1; | |||
| public hasResourceRole(user: any, role: string|undefined) { | |||
|
Changes Unknown when pulling 016acdb on JameelB:RAINCATCH-1276 into ** on feedhenry-raincatcher:master**. |
1 similar comment
|
Changes Unknown when pulling 016acdb on JameelB:RAINCATCH-1276 into ** on feedhenry-raincatcher:master**. |
wtrocki
reviewed
Oct 2, 2017
cloud/passportauth/example/index.ts
Outdated
| const secret = 'demo_secret'; | ||
| tokenAuthService.init(tokenRouter, undefined, secret); | ||
|
|
||
| tokenRouter.get('/token-login', (req: express.Request, res: express.Response) => { |
There was a problem hiding this comment.
Missing comments. There are two ways for that.
You can have two servers one for cookie one for token.
Or just mention that this endpoints are going to work with JWT etc.
wtrocki
previously approved these changes
Oct 2, 2017
|
Changes Unknown when pulling 1d25177 on JameelB:RAINCATCH-1276 into ** on feedhenry-raincatcher:master**. |
wtrocki
approved these changes
Oct 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is no documentation that covers token based authentication in PassportJS module. Our example does not cover this either. We need to provide information on how we use token based authentication.
Description
Update the documentation and the example to provide information on token based authentication and the JWT Strategy.
Progress
Additional Notes
Related JIRA - https://issues.jboss.org/browse/RAINCATCH-1276