This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtrocki
reviewed
Nov 30, 2017
|
||
echo "Rename root folder" | ||
cd $DOCS_LOCATION | ||
mv @raincatcher $VERSION | ||
mv $DOCS_LOCATION/@raincatcher $DOCS_LOCATION/$VERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was against all bash recommendations! thanks for fixing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a subshell would be okay too (cd $DOCS_LOCATION && mv ...)
Changes Unknown when pulling 6b4a4e4 on RAINCATCH-1399-docs-fix into ** on master**. |
Changes Unknown when pulling b8b3d72 on RAINCATCH-1399-docs-fix into ** on master**. |
1 similar comment
Changes Unknown when pulling b8b3d72 on RAINCATCH-1399-docs-fix into ** on master**. |
wtrocki
approved these changes
Nov 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix API documentation generation script
Description