RAINCATCH-1131 - wfm-users module #86
Conversation
wtrocki
requested review from
austincunningham,
JameelB,
paolobueno and
witmicko
as code owners
wtrocki
requested review from
JameelB
and removed request for
witmicko,
JameelB and
austincunningham
|
Changes Unknown when pulling 2f1a9c1 on wtrocki:RAINCATCH-1131 into ** on feedhenry-raincatcher:master**. |
| .then(() => this.get(object.id)).catch(err => { | ||
| const apiError = new ApiError(errorCodes.DB_ERROR, 'Cannot perform mongo query', 500, err); | ||
| return Bluebird.reject(apiError); | ||
| }); |
There was a problem hiding this comment.
You can DRY these error handlers into a single function
|
Changes Unknown when pulling fc057c1 on wtrocki:RAINCATCH-1131 into ** on feedhenry-raincatcher:master**. |
1 similar comment
|
Changes Unknown when pulling fc057c1 on wtrocki:RAINCATCH-1131 into ** on feedhenry-raincatcher:master**. |
|
Changes Unknown when pulling e363612 on wtrocki:RAINCATCH-1131 into ** on feedhenry-raincatcher:master**. |
1 similar comment
|
Changes Unknown when pulling e363612 on wtrocki:RAINCATCH-1131 into ** on feedhenry-raincatcher:master**. |
wtrocki
changed the title
|
Changes Unknown when pulling 42afdfb on wtrocki:RAINCATCH-1131 into ** on feedhenry-raincatcher:master**. |
|
All work done. Ready for review. Note: Created separate ticket to deal with bluebird. For the moment demo application is missing bluebird types which are resolving this issue: |
|
Changes Unknown when pulling 99f4465 on wtrocki:RAINCATCH-1131 into ** on feedhenry-raincatcher:master**. |
1 similar comment
|
Changes Unknown when pulling 99f4465 on wtrocki:RAINCATCH-1131 into ** on feedhenry-raincatcher:master**. |
wtrocki
force-pushed
the
RAINCATCH-1131
branch
from
99f4465
to
4b596d8
Compare
wtrocki
force-pushed
the
RAINCATCH-1131
branch
from
4b596d8
to
db1a705
Compare
|
Changes Unknown when pulling db1a705 on wtrocki:RAINCATCH-1131 into ** on feedhenry-raincatcher:master**. |
1 similar comment
|
Changes Unknown when pulling db1a705 on wtrocki:RAINCATCH-1131 into ** on feedhenry-raincatcher:master**. |
|
Changes Unknown when pulling 81c3474 on wtrocki:RAINCATCH-1131 into ** on feedhenry-raincatcher:master**. |
1 similar comment
|
Changes Unknown when pulling 81c3474 on wtrocki:RAINCATCH-1131 into ** on feedhenry-raincatcher:master**. |
There was a problem hiding this comment.
Looks like nothing's missing. Verified locally along with changes at feedhenry-raincatcher/raincatcher-angularjs#47
Motivation
WFM user module for purpose of user management.
For the moment it will be used only for fetching list of users to be listed in workflow creation screen.
Progress