[RAINCATCH-1021] release process #96

paolobueno · 2017-08-24T00:25:04Z

Motivation

Setup publishing to feedhenry templates for apps and npm publishing for modules

Progress

Add publishing to templates for demo-server
Add npm publishing for remainder packages
Add scripts to test publishing in travis
Documentation

coveralls · 2017-08-24T01:15:30Z

Changes Unknown when pulling fc285dc on RAINCATCH-1021-release-process into ** on master**.

coveralls · 2017-08-24T01:15:30Z

Changes Unknown when pulling fc285dc on RAINCATCH-1021-release-process into ** on master**.

wtrocki · 2017-08-24T12:32:38Z

scripts/publish-app.js

+var ghpages = require('gh-pages');
+var path = require('path');
+var fs = require('fs');
+var args = require('yargs')


Awesome work! Great to have command line tool for publishing packages.

wtrocki · 2017-08-24T12:56:27Z

scripts/publish-app.js

+var appName = args._[0];
+
+var appInfo = {
+  server: {


[Suggestion] It will be cool to have this as separate json later.
Nothing really needed. Just suggestion.

wtrocki · 2017-08-24T12:58:46Z

scripts/publish-app.js

+  add: true,
+  remote: 'origin',
+  repo: target.repo,
+  user: { name: "Wojciech Trocki", email: "wtrocki@redhat.com" },


I put my names to check if github user will be mapped (it works).
We may allow to override that? I'm not sure as mostly releases will be done by single person.

wtrocki · 2017-08-24T13:00:02Z

scripts/publish-app.js

+  branch: version,
+  dotfiles: true,
+  //Only add, and never remove existing files
+  add: true,


I was just using this for spike how repo size will change. add: true adds additional commit on top of the current changes. This will allow developers to see differences between releases. Not sure if we need it.

👍 considering we'll use branches named by version I don't think there's much difference in not having the add flag

wtrocki · 2017-08-24T13:03:06Z

scripts/test-publish.sh

@@ -0,0 +1,38 @@
+#!/bin/bash


💯 Awesome change! Really really good that we can test publishing without populating npm!

wtrocki · 2017-08-24T13:06:38Z

scripts/publish-app.js

+    repo: 'git@github.com:feedhenry-templates/wfm-server.git'
+  },
+  mobile: {
+    path: 'demo/mobile',


How this path is being executed? Curious as mobile is outside this repository.
Do you see us moving mobile to this repo by the time ?

I was only testing this with demo/server for now, I was hoping that if we reuse this same script from ~/raincatcher-angularjs/core/scripts, we mess around with the pwd so the relative path is correct.

paolobueno · 2017-08-28T22:52:53Z

To verify:

NPM publish for packages:

npm run publish:test
verify that publish finishes correctly and browser window is opened showling local registry docker image
download the contents of a package using npm pack @raincatcher/{module-name} --registry=http://localhost:{generated port}
verify that the contents of the package contain all required files (in particular compiled js files)

Templates publishing for apps

fork https://github.com/feedhenry-templates/wfm-server to your personal github account
npm run publish:demo-server -- -o {your github username} to push to that fork
during publishing, supply lerna with a version bump
verify that in your fork the correct branch is created with the contents of the server demo app

paolobueno · 2017-08-28T22:55:02Z

@wtrocki this is ready for verification

wtrocki · 2017-08-29T17:43:15Z

README.md

@@ -150,20 +150,21 @@ We recommend users to write their code in TypeScript, especially if their new Ra



Missing update to common folder in folder structure

wtrocki · 2017-08-29T17:52:41Z

cloud/wfm-demo-data/package.json

@@ -1,6 +1,6 @@
 {


Package is missing gitignore. js files are staged after release process.

wtrocki · 2017-08-29T18:10:45Z

lerna.json

+    },
+    "publish": {
+      "ignore": "@raincatcher/demo-server",
+      "exact": true


wtrocki · 2017-08-29T18:19:37Z

scripts/publish-prepare.sh

@@ -0,0 +1,10 @@
+#!/bin/bash
+set -ev
+npm run clean


I think we should also remove node_modules here and install stuff again to make sure that everything is clear.

wtrocki · 2017-08-29T18:25:48Z

@paolobueno I coudn't verify second part due to

lerna ERR! execute ../../cloud/auth/node_modules/@types/express-session/index.d.ts(20,7): error TS2374: Duplicate string index signature.

coveralls · 2017-08-29T23:21:19Z

Changes Unknown when pulling 262aa58 on RAINCATCH-1021-release-process into ** on master**.

paolobueno requested review from austincunningham, JameelB, witmicko and wtrocki as code owners August 24, 2017 00:25

feedhenry-raincatcher deleted a comment from coveralls Aug 24, 2017

wtrocki reviewed Aug 24, 2017

View reviewed changes

paolobueno force-pushed the RAINCATCH-1021-release-process branch 2 times, most recently from 4899bb9 to 66d7ad8 Compare August 25, 2017 13:02

paolobueno added 12 commits August 25, 2017 10:09

CHange lerna version to fixed, update all packages to 0.0.1

9ed94f8

Add publish commands, do not publish demo-server via lerna

6785264

Add publish script for apps

378d7aa

Add test publish script

a161598

Remove logger symlink

cd531a3

Add npm publish test to ci script

c104e06

Move logger to common/

bc1c97c

Add logging line

2aad1cb

Include test installation of published packages

b3d5bec

Add common dir to lerna packages

9e68e14

Fix package listing

d74805b

Add tsc compilation to build

d798049

paolobueno force-pushed the RAINCATCH-1021-release-process branch from 96423b9 to 968f3b1 Compare August 28, 2017 17:02

paolobueno added 3 commits August 28, 2017 19:39

use script dir as source path for apps.json

968bd3a

fix apps.json repos

946004f

Merge branch 'master' into RAINCATCH-1021-release-process

0bced13

paolobueno changed the title ~~WIP [RAINCATCH-1021] release process~~ [RAINCATCH-1021] release process Aug 29, 2017

paolobueno added 2 commits August 28, 2017 23:15

Add more ignores to test script

6c19659

Change git reset command

d5380bc

feedhenry-raincatcher deleted a comment from coveralls Aug 29, 2017

Add cli param for github org/user

b423d66

feedhenry-raincatcher deleted a comment from coveralls Aug 29, 2017

paolobueno mentioned this pull request Aug 29, 2017

[RAINCATCH-1021] release process feedhenry-raincatcher/raincatcher-angularjs#61

Merged

4 tasks

wtrocki reviewed Aug 29, 2017

View reviewed changes

cloud/wfm-demo-data/package.json

@@ -1,6 +1,6 @@

{

Copy link

Member

wtrocki Aug 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package is missing gitignore. js files are staged after release process.

wtrocki reviewed Aug 29, 2017

View reviewed changes

lerna.json

},

"publish": {

"ignore": "@raincatcher/demo-server",

"exact": true

Copy link

Member

wtrocki Aug 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

wtrocki reviewed Aug 29, 2017

View reviewed changes

paolobueno added 2 commits August 29, 2017 16:43

Add gitignore to demo-data

dcc54d7

Reinstall root modules too

262aa58

wtrocki approved these changes Aug 29, 2017

View reviewed changes

paolobueno merged commit 1e63c80 into master Aug 30, 2017

paolobueno deleted the RAINCATCH-1021-release-process branch August 30, 2017 14:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RAINCATCH-1021] release process #96

[RAINCATCH-1021] release process #96

paolobueno commented Aug 24, 2017 •

edited

Loading

coveralls commented Aug 24, 2017

coveralls commented Aug 24, 2017

wtrocki Aug 24, 2017

wtrocki Aug 24, 2017

wtrocki Aug 24, 2017

wtrocki Aug 24, 2017 •

edited

Loading

paolobueno Aug 24, 2017

wtrocki Aug 24, 2017

wtrocki Aug 24, 2017

paolobueno Aug 24, 2017

paolobueno commented Aug 28, 2017 •

edited

Loading

paolobueno commented Aug 28, 2017

wtrocki Aug 29, 2017

wtrocki Aug 29, 2017

wtrocki Aug 29, 2017

wtrocki Aug 29, 2017

wtrocki commented Aug 29, 2017

coveralls commented Aug 29, 2017 •

edited

Loading

		@@ -150,20 +150,21 @@ We recommend users to write their code in TypeScript, especially if their new Ra

[RAINCATCH-1021] release process #96

[RAINCATCH-1021] release process #96

Conversation

paolobueno commented Aug 24, 2017 • edited Loading

Motivation

Progress

coveralls commented Aug 24, 2017

coveralls commented Aug 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wtrocki Aug 24, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paolobueno commented Aug 28, 2017 • edited Loading

paolobueno commented Aug 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wtrocki commented Aug 29, 2017

coveralls commented Aug 29, 2017 • edited Loading

paolobueno commented Aug 24, 2017 •

edited

Loading

wtrocki Aug 24, 2017 •

edited

Loading

paolobueno commented Aug 28, 2017 •

edited

Loading

coveralls commented Aug 29, 2017 •

edited

Loading