Sync bugfixes #55
Sync bugfixes #55
Conversation
…al record don't delete the local record.
…g updates will no longer be overwritten by server side changes
…ead of the Hash value. This is because the hash is the value keyed in the local data cache. If the has has changed since the data was created then when the application restarts these values won't match and phantom data will exist
…r it won't be notified. This usually happens if the server crashes. In this case we will want to verify that we ARE still waiting for an update. If such an update can not be found then we need to clear the delayed flag and continue with running.
…nger the case. I have added checks for this condition as well
| updateNewDataFromPending(pData); | ||
|
|
||
| boolean hasRecords = false; | ||
|
|
||
| if (pData.has("records")) { |
There was a problem hiding this comment.
this can be removed. As well as the resetDataset. It should be removed from the ios and wp sdk too.
|
reviewed. |
|
@wei-lee @secondsun do we know what version this will be yet? 2.4.1? |
|
@david-martin This hasn't been tested against Gingerbread and testing in Gingerbread has not been a priority . Unless we are planning to test GBread with this PR I would not suggest using the 2.x.x version. |
|
@secondsun @david-martin I think we will go with 2.4.1, treat it as a bug fixes for the current version. We can have another 3.x release with support for android M. |
|
@secondsun @david-martin Just had a quick discussion with Dave and Jason and we think 2.5.0 probably is the best option here. |
|
Something I just noticed, master already has android M dependencies. We need to create a branch of the 2.x line and merge this in there and not into master if we are going to be calling this 2.x |
@wei-lee @danielpassos
This is the sync work so far