Coverage #28
Merged
Coverage #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edewit 👀 |
|
@edewit since Appveyor is using MS VS 12.0 maybe moving MSTestFramework to 12.0 will help getting rid of " Could not find SDK "MSTestFramework, Version=14.0" I've also noticed that we have more warning on undocumented filed since you move them from private to public. maybe a separate PR to remove all warnings. |
|
@edewit no luck, i'm closing PR |
|
@corinnekrych your suggestion worked now it builds successful |
|
@edewit Just did a PR on your branch to remove some warnings. |
…entation.missing.warning Add XML doc to clear warning from appveyor CI build
|
what is wrong with the build? |
|
@edewit +1 to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to use test that use mocks instead of running node server, target windows 8.1 and 8.0 xamarin ios and android