Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search fix #10

Merged
merged 2 commits into from
Aug 30, 2017
Merged

Search fix #10

merged 2 commits into from
Aug 30, 2017

Conversation

jhellar
Copy link
Member

@jhellar jhellar commented Jun 23, 2017

witmicko
witmicko reviewed Jun 23, 2017
View reviewed changes
Copy link
Contributor

@witmicko witmicko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, needs a prerelease version bump tough.
might add unit test for search here https://github.com/feedhenry/fh-forms/blob/master/test/unit/middleware/test_forms.js

@witmicko witmicko changed the base branch from master to RHMAP-1157-Repeating_Sections August 30, 2017 10:27
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.029% when pulling df2a163 on jhellar:RHMAP-16402 into 6c1c229 on feedhenry:RHMAP-1157-Repeating_Sections.

@witmicko witmicko merged commit 0c8590a into feedhenry:RHMAP-1157-Repeating_Sections Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@witmicko witmicko witmicko left review comments

@nialldonnellyfh nialldonnellyfh Awaiting requested review from nialldonnellyfh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhellar @coveralls @witmicko