Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHMAP-20442 : Add scripts to update the licenses automatically #50

Closed
wants to merge 2 commits into from
Closed

RHMAP-20442 : Add scripts to update the licenses automatically #50

wants to merge 2 commits into from

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented May 14, 2018 •
edited

JIRA:

https://issues.jboss.org/browse/RHMAP-20442

WHAT:

  • Add lock dependencies file (npm-shrinkwrap.json)
  • Add licenses
  • Add scripts to update the licenses automatically

WHY:

It is a RedHat pre-requirement.

Steps to test:

Check if the CI process finalized with success.

@coveralls
Copy link

coveralls commented May 14, 2018 •
edited

Coverage Status

Coverage decreased (-0.01%) to 74.969% when pulling f6252bb on camilamacedo86:RHMAP-20442 into cbd257a on feedhenry:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 74.969% when pulling c588a5f on camilamacedo86:RHMAP-20442 into cbd257a on feedhenry:master.

@camilamacedo86 camilamacedo86 changed the title Rhmap 20442 RHMAP-20442 : Add scripts to update the licenses automatically May 14, 2018
grdryn
grdryn requested changes May 14, 2018
View reviewed changes
Copy link
Member

@grdryn grdryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think any of these changes are needed or worthwhile. We don't typically add all the license stuff (or a shrinkwrap file) for the non-component projects.

@camilamacedo86
Copy link
Contributor Author

Closed as won't do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grdryn grdryn grdryn requested changes

@austincunningham austincunningham Awaiting requested review from austincunningham

@davidffrench davidffrench Awaiting requested review from davidffrench

@damienomurchu damienomurchu Awaiting requested review from damienomurchu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@camilamacedo86 @coveralls @grdryn