This repository has been archived by the owner on Dec 19, 2017. It is now read-only.
refactoring #62
Merged
refactoring #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philbrookes FYI moving things around a bit nothing major. Will merge once it passes |
philbrookes
suggested changes
Sep 13, 2017
pkg/mobile/integration/service.go
Outdated
| @@ -130,15 +117,16 @@ func (ms *MobileService) MountSecretForComponent(svcCruder mobile.ServiceCruder, | |||
| } | |||
|
|
|||
| //find the clientService secret name | |||
| css, err := svcCruder.List(ms.filterServices([]string{clientService})) | |||
| if err != nil || len(css) == 0 { | |||
| cSeviceList, err := svcCruder.List(filterServices([]string{clientService})) | |||
pkg/mobile/types.go
Outdated
| @@ -94,6 +94,9 @@ func (at AppTypes) String() string { | |||
| //ValidAppTypes is a list of valid app types | |||
| var ValidAppTypes = AppTypes{"cordova", "android", "iOS"} | |||
|
|
|||
| //ServiceTypes are the service types that we are aware of and support | |||
| var ServiceTypes = []string{"fh-sync-server", "keycloak", "custom"} | |||
There was a problem hiding this comment.
I'm uncomfortable with this in general - not specific to this PR; I don't like that we have to recompile, rebuild and redeploy the API server anytime we want to add a new mobile service.
There was a problem hiding this comment.
yes agree, however I am chatting with the service catalog guys around having labels on the secrets kubernetes-retired/service-catalog#1222 which I think will help. Also can be moved out to an env var at somepoint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving client pkg out of mobile pkg. Some other general refactors and additional tests