Skip to content

Commit

Permalink
add new date filter to stop messing with DATE_FORMAT
Browse files Browse the repository at this point in the history
  • Loading branch information
brutasse committed Mar 15, 2017
1 parent 3bf057f commit 6f3144a
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 6 deletions.
3 changes: 0 additions & 3 deletions feedhq/feeds/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -773,9 +773,6 @@ def oauth_client(self, service):
creds['oauth_token_secret'])
return auth

def current_year(self):
return self.date.year == timezone.now().year


class Entry(BaseEntry, models.Model):
"""An entry is a cached feed item"""
Expand Down
2 changes: 1 addition & 1 deletion feedhq/feeds/templates/feeds/entry_links.html
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<div class="date" title="{{ object.date|date:"c" }}">{% if object.current_year %}{{ object.date|timezone:user.timezone|date }}{% else %}{{ object.date|timezone:user.timezone|date:"DATE_FORMAT" }}{% endif %} - <a{% if object.feed.favicon %} style="background-image: url('{{ object.feed.favicon.url }}'); padding-left: 20px;"{% endif %} href="{{ object.link }}">{{ object.link_domain }}</a>{% if object.read_later_url %} - <a href="{{ object.read_later_url }}">{{ object.read_later_domain }}</a>{% endif %}</div>
{% load feeds_tags %}<div class="date" title="{{ object.date|date:"c" }}">{{ object.date|timezone:user.timezone|smart_datetime }} - <a{% if object.feed.favicon %} style="background-image: url('{{ object.feed.favicon.url }}'); padding-left: 20px;"{% endif %} href="{{ object.link }}">{{ object.link_domain }}</a>{% if object.read_later_url %} - <a href="{{ object.read_later_url }}">{{ object.read_later_domain }}</a>{% endif %}</div>
8 changes: 8 additions & 0 deletions feedhq/feeds/templatetags/feeds_tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,11 @@ def smart_date(value):
return value.strftime('%H:%M')
return value.strftime('%b %d')
return value.strftime('%b %d, %Y')


@register.filter
def smart_datetime(value):
now = timezone.localtime(timezone.now(), value.tzinfo)
if value.year == now.year:
return value.strftime('%b %d, %H:%M')
return value.strftime('%b %d, %Y')
2 changes: 0 additions & 2 deletions feedhq/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,6 @@ def parse_redis_url():
LOGIN_URL = reverse_lazy('login')
LOGIN_REDIRECT_URL = reverse_lazy('feeds:entries')

DATE_FORMAT = 'M j, H:i'

LOGGING = {
'version': 1,
'disable_existing_loggers': False,
Expand Down

0 comments on commit 6f3144a

Please sign in to comment.