Support for URLs in GUIDs. #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @benubois Unfortunately, I just merged a PR that moves this code since it is shared between a couple feed types. I'll try to manually apply this change, but if you resolve the conflicts before I can do that, I won't be sad. 😄 |
knu
reviewed
Jul 31, 2019
lib/feedjira/parser/rss_entry.rb
Outdated
| def id | ||
| @entry_id ||= @dc_identifier || @url | ||
| entry_id || @dc_identifier || @url |
There was a problem hiding this comment.
These lines now belong to lib/feedjira/rss_entry_utilities.rb, so please merge (or rebase onto) master and apply the change to it.
Use the presence of the isPermaLink attribute to determine if the GUID should be used for the URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I came across a feed that uses only
<guid isPermaLink="true">tags to specify URLs.This pull request adds support for this type of url.
According to the RSS 2.0 spec:
My interpretation is that the
<guid>is supposed to be the url of the entry, unlessisPermaLink="false"is specified.To ensure the output is as consistent with previous releases as possible, this patch also prefers urls specified in
<link>tags when both a<guid>and<link>are present.Thanks!