Enable more tests #297
Merged
Enable more tests #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jmf-tls
commented
Feb 14, 2022
jmf-tls
commented
- Create missing profiles for H2, in pom and github workflows
- Add test classpath for H2 remote, so that UDF tests can run
- Make each H2 test config use different directories/ports
- Enable CockroachDB engine schema tests (required upgrading Docker image version, due to a bug Cannot read floating point infinity values from JDBC cockroachdb/cockroach#62601)
- Add flag to MySQL test configs to allow connecting to newer versions of the server
- Other improvements and cleanups
* Create missing profiles for H2, in pom and github workflows * Add test classpath for H2 remote, so that UDF tests can run * Make each H2 test config use different directories/ports * Enable CockroachDB engine schema tests (required upgrading Docker image version, due to a bug cockroachdb/cockroach#62601) * Add flag to MySQL test configs to allow connecting to newer versions of the server * Other improvements and cleanups
jmf-tls
requested review from
hugomiguelabreu,
jcsf,
nuno-v-santos and
upsidedownsmile
|
Overall LGTM |
hugomiguelabreu
approved these changes
Feb 14, 2022
ctosin
approved these changes
Feb 14, 2022
upsidedownsmile
approved these changes
Feb 14, 2022
src/test/java/com/feedzai/commons/sql/abstraction/engine/testconfig/DatabaseTestUtil.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.