Try to reconnect at max 3x when connection is down in AbstractDatabaseEngine#getPSIterator
#387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seEngine#getPSIterator` It was found out that sometimes the connection to the Database could be lost when calling the method AbstractDatabaseEngine#createResultIterator. In order to make it reconnect and redo the desired query, this commit makes the method AbstractDatabaseEngine#getPSIterator call the `AbstractDatabaseEngine#createResultIterator` at maximum 3 times, where in each attempt, it reconnects to the database first. By doing this, it avoids the PDB user to having to manually reconnect the connection and redo all the `PreparedStatements` as reported in the exception that was being thrown "Connection was lost and restablished. You need to reset the prepared statement parameters and re-execute the statement."
TiagoMSSantos
force-pushed
the
ft-ts-retry-getPSIterator
branch
from
54167c9
to
c2c677b
Compare
|
It seems that doing this retry mechanism is unnecessary and should be done by the user of PDB instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found out that sometimes the connection to the Database could be lost when calling the method
AbstractDatabaseEngine#createResultIterator.In order to make it reconnect and redo the desired query, this commit makes the method
AbstractDatabaseEngine#getPSIteratorcall theAbstractDatabaseEngine#createResultIteratorat maximum 3 times, where in each attempt, it reconnects to the database first.By doing this, it avoids the PDB user to having to manually reconnect the connection and redo all the
PreparedStatementsas reported in the exception that was being thrownConnection was lost and restablished. You need to reset the prepared statement parameters and re-execute the statement.