Add Support to Upsert/Insert Ignore on PDB #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Makes the implementation of DatabaseEngine optional, so it does not break compatibility with other library clients.
- Addresses comments: changes message in the default method implementation.
- Adds support for the following engines: MySQL, DB2. - Adds an exception to being thrown when a merge is not possible and use a `MappedEntity` without an `UPSERT` statement.
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/DB2Engine.java
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/DB2Engine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/DB2Engine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/H2Engine.java
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/H2Engine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/MySqlEngine.java
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/MySqlEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/PostgreSqlEngine.java
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/PostgreSqlEngine.java
Outdated
Show resolved
Hide resolved
- Addresses comments
diogo-anjos-fdz
previously approved these changes
Jun 29, 2023
There was a problem hiding this comment.
LGTM! but there are some unit tests failing, please review this change:
5ad2cb6#diff-bc62c5f9b00d089dc441b48954a5fee8fc5f051ef41115def9ac371e580a9285R519
diogo-anjos-fdz
dismissed
their stale review
some unit tests need first to be addressed
- Fix H2Engine variable initialization
- Adds `max-parallel` property to only run one JVM per run.
|
Great, great troubleshooting work Victor! 😃 Kudos! 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MappedEntitywithout anUPSERTstatement.