Add some logs while Postgres queries are being executed #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiagoMSSantos
force-pushed
the
ft-ts-add-logs-while-doing-postgres-queries
branch
9 times, most recently
from
bed8274
to
a1e26a8
Compare
TiagoMSSantos
force-pushed
the
ft-ts-add-logs-while-doing-postgres-queries
branch
from
a1e26a8
to
59b74ba
Compare
TiagoMSSantos
force-pushed
the
ft-ts-add-logs-while-doing-postgres-queries
branch
4 times, most recently
from
08f48ac
to
561a406
Compare
TiagoMSSantos
commented
Aug 23, 2023
src/test/java/com/feedzai/commons/sql/abstraction/engine/impl/abs/EngineIsolationTest.java
Outdated
Show resolved
Hide resolved
TiagoMSSantos
force-pushed
the
ft-ts-add-logs-while-doing-postgres-queries
branch
9 times, most recently
from
867c029
to
d22ecf4
Compare
TiagoMSSantos
force-pushed
the
ft-ts-add-logs-while-doing-postgres-queries
branch
2 times, most recently
from
adf2db8
to
daeb1dd
Compare
helenapoleri
approved these changes
Aug 28, 2023
artpdr
reviewed
Aug 29, 2023
src/test/java/com/feedzai/commons/sql/abstraction/engine/impl/abs/EngineIsolationTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/PostgreSqlEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/PostgreSqlEngine.java
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/PostgreSqlEngine.java
Outdated
Show resolved
Hide resolved
TiagoMSSantos
force-pushed
the
ft-ts-add-logs-while-doing-postgres-queries
branch
4 times, most recently
from
d3938ca
to
a6c1585
Compare
helenapoleri
approved these changes
Aug 29, 2023
TiagoMSSantos
force-pushed
the
ft-ts-add-logs-while-doing-postgres-queries
branch
2 times, most recently
from
649dd14
to
a703b87
Compare
artpdr
reviewed
Aug 29, 2023
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/PostgreSqlEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/PostgreSqlEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/PostgreSqlEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/PostgreSqlEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/PostgreSqlEngine.java
Outdated
Show resolved
Hide resolved
TiagoMSSantos
force-pushed
the
ft-ts-add-logs-while-doing-postgres-queries
branch
3 times, most recently
from
01d1690
to
573d1c0
Compare
artpdr
reviewed
Aug 29, 2023
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/PostgreSqlEngine.java
Outdated
Show resolved
Hide resolved
This commit adds some extra logs to be shown while Postgres queries are being executed. The goal is to easily identify cases where a query is not being executed because it's waiting for the Database table to be unlocked first (due to another query being already executed for example). Since it's not easy to identify a query timeout that will work for all cases of queries that can be executed with PDB, at least being able to see in the logs that PDB is still executing a query helps to identify such scenarios.
TiagoMSSantos
force-pushed
the
ft-ts-add-logs-while-doing-postgres-queries
branch
from
573d1c0
to
3248746
Compare
artpdr
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some extra logs to be shown while Postgres queries are being executed. The goal is to easily identify cases where a query is not being executed because it's waiting for the Database table to be unlocked first (due to another query being already executed for example). Since it's not easy to identify a query timeout that will work for all cases of queries that can be executed with PDB, at least being able to see in the logs that PDB is still executing a query helps to identify such scenarios.