Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes error logging for UPSERT command when creating an entity #407

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

victorcmg
Copy link
Contributor

This commit removes an unnecessary stack trace logging when an entity is created on pdb and it has no primary keys.

victorcmg-fdz and others added 4 commits October 10, 2023 09:54
- Removes error logging for the UPSERT prepared statements for entities that have no MERGE/UPSERT prepared statement associated to it.
- Changes log level and edits log message.
@diogo-anjos-fdz
Copy link

LGTM!

@victorcmg-fdz
Copy link
Collaborator

Just so it keeps documented, the tests sometimes are failing on the H2 engine.

The same behavior could be seen locally and it seems related to the latest automatic bumps on the h2 dependency. The tests made rolled-back (locally) to the previous version before the bump, e.g. 2.1.214 and all tests succeeded. On the other hand, when bumping the dependency to its latest version 2.2.224 the tests tend to fail. The same behavior was seen during the tests in this PR and also throughout the commit history since the bumps have been committed to the main branch. So, most likely, the flakiness regarding the pdb master branch is due to the bumping of this library (and even maybe other ones).

The test ran locally were a way to sanity check that this PR would not be introducing any other issue to the main branch.

@victorcmg-fdz victorcmg-fdz merged commit 94ba1a5 into feedzai:master Oct 17, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants