Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prudhomm/issue1533 #1535

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Prudhomm/issue1533 #1535

merged 3 commits into from
Nov 4, 2020

Conversation

prudhomm
Copy link
Member

@prudhomm prudhomm commented Nov 4, 2020

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes?
  • Have you successfully run the Feel++ testsuite with your changes locally?
  • Have you written Doxygen comments in your contribution ?

This involves

This PR allows to handle situation where we don't have access to command line options such as in ipython or colab.

regarding #1533 it allows to change the json to our liking and run the simulations without having to save the json and load it with the command line options

add setConfigFile to Environment to setup the option variable_map
set model properties from file name and json
@prudhomm prudhomm merged commit c873dca into develop Nov 4, 2020
@prudhomm prudhomm deleted the prudhomm/issue1533 branch November 4, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants