Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/meshstructured #1622

Merged
merged 8 commits into from
Jun 4, 2021
Merged

Feature/meshstructured #1622

merged 8 commits into from
Jun 4, 2021

Conversation

vincentchabannes
Copy link
Member

@vincentchabannes vincentchabannes commented May 28, 2021

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes?
  • Have you successfully run the Feel++ testsuite with your changes locally?
  • Have you written Doxygen comments in your contribution ?

MeshStructured features :

  • 1d/2d/3d with hypercube element (TODO : Simplex)
  • geometry currently available: hyperrectangle. The setup of the geometry is given by a json file, see examples in test_meshstructured. (TODO : other shapes as for example an arbitrary Quadrangle(2d) or QuadrilaterallyFacedHexahedron(3d) by using geo transformation of hypercube).
  • partitioning currently available: striped one direction (TODO : by block)

@prudhomm It will break some code that uses MeshStructured :

  • template parameters of class MeshStructured
  • constructor args

Copy link
Member

@prudhomm prudhomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test for the case with coordinates ? I found one but it is commented out

inline
AboutData
makeAbout()
#if 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test does not work with coordinates ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the coordinates test is here. These lines commented was a hbf test but it was always commented before my changes.

@prudhomm
Copy link
Member

nice job for refactoring this

@vincentchabannes vincentchabannes merged commit fa0ba54 into develop Jun 4, 2021
@vincentchabannes vincentchabannes deleted the feature/meshstructured branch October 18, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants