Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix geometry of thermal-fin #1671

Merged
merged 3 commits into from
Sep 21, 2021
Merged

fix geometry of thermal-fin #1671

merged 3 commits into from
Sep 21, 2021

Conversation

thomas-saigre
Copy link
Contributor

add fins in layers and fix template
[ci skip]

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes?
  • Have you successfully run the Feel++ testsuite with your changes locally?
  • Have you written Doxygen comments in your contribution ?

add fins in layers and fix template
[ci skip]
@thomas-saigre thomas-saigre removed the request for review from prudhomm July 19, 2021 13:11
@prudhomm
Copy link
Member

is the application installed with the documentation ?
why in mor/toolbox-mor?
I would suggest

  • toolboxes/generators/cases/thermal-fin -> geometry + cfg/json
    no ?

also the generated geo file should contain

/cc @thomas-saigre @romainhild

@thomas-saigre
Copy link
Contributor Author

@prudhomm I documented in https://github.com/feelpp/feelpp/blob/saigre/fix-thermal-fin/mor/toolbox-mor/thermal-fin/case_generator.adoc
I can move those files in the drectory toolboxes/generators/cases/thermal-fin if it make more sense than where it is now. I think I put it in mor becausethe case was build for this toolbox, but we can indeed use is with another toolbox

@prudhomm
Copy link
Member

you generate the json file as well ?

@prudhomm
Copy link
Member

we could be indeed interested in different physics, eg solid and fluid mechanics

@thomas-saigre
Copy link
Contributor Author

you generate the json file as well ?

Yes the json is part of the templates

@prudhomm
Copy link
Member

the application could generate the json for different physics, in case of fluid mechanics the fin needs to be in a box

@prudhomm
Copy link
Member

feelpp_case_generator should be renamed feelpp_case_generator_thermal_fin

@prudhomm prudhomm merged commit 7cf3162 into develop Sep 21, 2021
@prudhomm prudhomm deleted the saigre/fix-thermal-fin branch September 21, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants