-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/toolboxes refactoring hdg #1715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add empty() to ModelMarkers
This reverts commit 2a3e762.
it find the ic for which the time is greater or equal to the requested time with lower_bound. if not found it uses the greater time available. we need to update the other toolboxes to pass priorTimes as argument
@vincentchabannes you can now finish your review. |
ctest will print the output only if the test fails
…/feelpp into feature/toolboxes-refactoring-hdg
vincentchabannes
approved these changes
Oct 28, 2021
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of the MixedPoisson Toolbox to be as close as possible to the other toolboxes.
Modification of coupled mixed poisson, poroelastic and thermoelectric to work with the latest version of the toolbox.
Add tests for each application.