-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic finite element matrices construction in python #1739
Conversation
Fixes #1738 other matrices can be added in the future skip components
@vincentchabannes the PR is only on the python version, no need to check the toolboxes or mor |
@@ -1,4 +1,4 @@ | |||
cmake_minimum_required(VERSION 3.3) | |||
cmake_minimum_required(VERSION 3.21) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a big constraint, most OS doesn't are to this level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not used currently and will be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is used only by cmake preset which works only at cmake 3.21.
python codes will move there and the cmakelists,txt will be updated properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was added by mistake, I can of course lower the version but it has not impact for now except for those using cmake --preset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So OK, If you are sure that cmake doesn't failed for a basic use (without preset and thus also lower version)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the main cmakelist does not add_subdirectory
pyfeelpp-all for now (only via preset)
Fixes #1738
other matrices can be added in the future
skip components