Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic finite element matrices construction in python #1739

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

prudhomm
Copy link
Member

@prudhomm prudhomm commented Dec 7, 2021

Fixes #1738

other matrices can be added in the future

skip components

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes?
  • Have you successfully run the Feel++ testsuite with your changes locally?
  • Have you written Doxygen comments in your contribution ?

Fixes #1738

other matrices can be added in the future

skip components
@prudhomm prudhomm self-assigned this Dec 7, 2021
@prudhomm prudhomm added the 🐍 module:python python support label Dec 7, 2021
@prudhomm prudhomm added this to the v110 milestone Dec 7, 2021
@prudhomm
Copy link
Member Author

prudhomm commented Dec 7, 2021

@vincentchabannes the PR is only on the python version, no need to check the toolboxes or mor
some tests/examples have been added

@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.3)
cmake_minimum_required(VERSION 3.21)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a big constraint, most OS doesn't are to this level.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not used currently and will be changed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is used only by cmake preset which works only at cmake 3.21.
python codes will move there and the cmakelists,txt will be updated properly

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was added by mistake, I can of course lower the version but it has not impact for now except for those using cmake --preset

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So OK, If you are sure that cmake doesn't failed for a basic use (without preset and thus also lower version)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the main cmakelist does not add_subdirectory pyfeelpp-all for now (only via preset)

@prudhomm prudhomm merged commit f87256d into develop Dec 7, 2021
@prudhomm prudhomm deleted the prudhomm/issue1738 branch December 7, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐍 module:python python support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add basic finite element matrices construction in python
2 participants