Feature/toolboxes #1769

vincentchabannes · 2022-01-28T22:19:31Z

Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes?
Have you successfully run the Feel++ testsuite with your changes locally?
Have you written Doxygen comments in your contribution ?

Implement Replace Boost::PropertyTree by nl::json in Toolboxes #1728 : all model properties except BoundaryConditions has been done
Refactoring and clean of ModelMaterials : Support more kinds of properties in Materials Section #1772 Support indexes in Json Section Materials #1758
New design of Models section and how it use in all toolboxes Refactoring Json Models section #1764 . Implementation in toolbox not finished but the internal design is good now. The physics parameters in ModelMaterials is now deprecated!
Implement Update Json format in Section InitialConditions #1760
Up convergence mode : check convergence rate
Heat Toolbox
- Heat source are now defined in Models section : two kind are available heat-source or heat-rate
- New tests
Some fix with internalfaces integration + some new feature with toolboxes measure on internal faces integration, see doc

WARNING : these changes has required to fix all json (or almost). This is the first phase. The next phase will be full refactoring of boundaryconditions

…toolbox_fluid_turbulence

…' into feature/toolboxes

…hGhostsSplitted + mv some part in trait.hpp

…en eval on interprocess some expr using the exprselectorbymeshelement

prudhomm · 2022-01-31T05:11:39Z

feelpp/feel/feelalg/backend.cpp

@@ -464,8 +464,11 @@ Backend<T,SizeT>::nlSolve( sparse_matrix_ptrtype& A,
    }
    else if ( !ret.isConverged() )
    {
-        LOG(ERROR) << "\n[backend] non-linear solver fail";
-        LOG(ERROR) << "Backend " << M_prefix << " : non-linear solver failed to converge" << std::endl;
+        if ( this->worldComm().isMasterRank() )


LOG() is supposed to do that, isn't it the case ?

or may be it is the wrong WorldComm ?

prudhomm · 2022-01-31T05:17:17Z

feelpp/feel/feelmodels/modeloutputs.cpp

-        exit(1);
+    if ( !M_p.contains("key") )
+    {
+        CHECK( false ) << "invalid key";


a more explicit message here to help find where could be the problem

indeed, I will review errors when exception will be full operational

prudhomm · 2022-01-31T05:17:27Z

feelpp/feel/feelmodels/modeloutputs.cpp

+    auto const& j_key =  M_p.at("key");
+    if ( !j_key.is_string() )
+    {
+        CHECK( false ) << "invalid key";


prudhomm · 2022-02-10T04:16:25Z

toolboxes/feel/feelmodels/fluid/fluidmechanicscreate.cpp

@@ -985,8 +985,14 @@ FLUIDMECHANICS_CLASS_TEMPLATE_TYPE::init( bool buildModelAlgebraicFactory )
    this->log("FluidMechanics","init", "start" );
    this->timerTool("Constructor").start();

-    if ( this->physics().empty() )
-        this->initPhysics( this->keyword(), this->modelProperties().models() );
+#if 1


to be removed....

toolboxes/feel/feelmodels/fluid/fluidmechanicscreate.cpp

prudhomm · 2022-02-10T04:25:58Z

toolboxes/feel/feelmodels/hdg/poroelastic.hpp

@@ -216,7 +216,10 @@ MixedPoissonElasticity<Dim,Order,G_Order,E_Order>::assembleF_Elasticity()
    for( auto const& pairMat : M_ElasticityModel->modelProperties().materials() )
    {
        auto material = pairMat.second;
+#if 0


probably an unfinished business

toolboxes/feel/feelmodels/heat/heat.cpp

prudhomm · 2022-02-10T05:19:48Z

toolboxes/feel/feelmodels/solid/solidmechanicsothers.cpp

    nl::json subPt;
    subPt.emplace( "time mode", std::string( (this->isStationary())?"Stationary":"Transient") );
-    p["Physics"] = subPt;
+    p["Physics2"] = subPt;


prudhomm · 2022-02-10T05:28:12Z

toolboxes/pyfeelpp-toolboxes/tests/test_cfpdes.py

-    nl_case_t = cfpdes(dim=dim)
-    simulate(nl_case_t)
-    return not nl_case_t.checkResults()
+# def test_cfpde_nlthermoelectric():


currently, can not work in seq and parallel together (sometimes work, sometimes not). I have also a strange behavior when the number of proc increase, maybe a bug somewhere, to investigate

it was working in the automated tests via ctest in both seq and par cases.
when did you see the problem ?

because the mesh is repartitioned and this partitioning is not always the same. The field loaded can be wrong (something crash if dofs are not compatible). Currently, in sequential we use a .msh and in // a partitioned mesh .json, both case can't be take into account in one config.
Another issue is when the number of proc increases (for example > 20 ), there is something wrong in the automatic diff I think but not very clear, I need to continue my investigation.

vincentchabannes · 2022-02-25T14:20:35Z

@prudhomm I didn't see that you have approved the PR, so I will merge when the CI will be finished. I need to finish the doc, next week

prudhomm · 2022-02-26T17:37:15Z

sorry I thought I pinged you about that. took me some time to go through all the code

prudhomm · 2022-02-27T07:03:31Z

@vincentchabannes we have this issue in this PR: https://buildkite.com/feelpp/feelpp/builds/4185#11a70d25-8a72-4960-9f96-44580bdd3359/265-505

vincentchabannes added 30 commits July 9, 2021 09:23

work on turbulence model k-epsilon

8ec35d9

up case

44b2094

work on k-epsilon

197e195

up

20061b4

up #1728 in ModelPostprocess

eb83eb6

up #1728 in ModelMaterials + fix #1758

931c454

up #1728

e6bef7f

up #1728

1b2b08d

add test for #1758

2fd0e65

up #1728 : ModelOutputs and ModelParameters

48e48c3

up #1728

ae8f868

fix compilation

bbb8c22

up #1728

98a04b7

up #1728 + remove deprecated ModelFunctions

3b3a8c4

up #1728

19ed453

fix

94b400c

up #1728 with ModelInitialConditions + implement #1760

6c5c571

fix from changes in initialConditions

c24f8cf

fix json InitialConditions with #1760

3bde442

some up

bf24336

put off TurbulentKineticEnergy : go in pressure

142b17f

Merge remote-tracking branch 'origin/feature/toolboxes' into feature/…

1515671

…toolbox_fluid_turbulence

start work on heat physic

d4ca848

Merge remote-tracking branch 'origin/feature/toolbox_fluid_turbulence…

14b0488

…' into feature/toolboxes

Merge remote-tracking branch 'origin/feature/toolbox_fluid_turbulence…

3f3584d

…' into feature/toolboxes

up #1764

9b83378

up #1764

3ffa1cb

up #1764

5a199b4

up #1764

628f4dc

up #1764 #1728

73864ec

vincentchabannes added 20 commits February 8, 2022 13:12

fix with last changes (wip)

c37ba75

sync values on ghosts

bd8c8e6

clean #1494

cec9e0d

up measure on internalfaces with in Statistics

f077b70

up EvalOnFaces constructor : universal ref works now

001d9f4

up MeasuresNormalHeatFlux : support internalfaces

62e9173

up test

2916901

fix quad from json if given as string

838388c

up Evaluator : support internalfaces

8996040

fix compilation

1311ae7

up test

d32c297

up

7b73b6a

clean

f376960

clean

fda9979

remove useless file

6629d8b

fix Evaluator with internalfaces on //

98cd296

up mesh filters : add new filter called collectionOfMarkedelementsWit…

a4a336d

…hGhostsSplitted + mv some part in trait.hpp

up MaterialsOnMesh : setup also markedelements on ghost : required wh…

958345d

…en eval on interprocess some expr using the exprselectorbymeshelement

add min op + clean

420bee4

fix compilation

a6f5268

prudhomm approved these changes Feb 10, 2022

View reviewed changes

vincentchabannes added 3 commits February 10, 2022 08:00

Merge remote-tracking branch 'origin/develop' into feature/toolboxes

7697a2d

Merge remote-tracking branch 'origin/develop' into feature/toolboxes

ce95ec0

Merge branch 'develop' into feature/toolboxes

9dca89d

Merge remote-tracking branch 'origin/develop' into feature/toolboxes

d8da51b

fix compilation

fafd2d1

vincentchabannes merged commit 7fc59b4 into develop Feb 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/toolboxes #1769

Feature/toolboxes #1769

vincentchabannes commented Jan 28, 2022 •

edited

prudhomm Jan 31, 2022

prudhomm Jan 31, 2022

prudhomm Jan 31, 2022

vincentchabannes Feb 25, 2022

prudhomm Jan 31, 2022

prudhomm Feb 10, 2022

prudhomm Feb 10, 2022

prudhomm Feb 10, 2022

prudhomm Feb 10, 2022

vincentchabannes Feb 25, 2022 •

edited

prudhomm Feb 26, 2022

vincentchabannes Feb 27, 2022

vincentchabannes commented Feb 25, 2022

prudhomm commented Feb 26, 2022

prudhomm commented Feb 27, 2022

Feature/toolboxes #1769

Feature/toolboxes #1769

Conversation

vincentchabannes commented Jan 28, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vincentchabannes Feb 25, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vincentchabannes commented Feb 25, 2022

prudhomm commented Feb 26, 2022

prudhomm commented Feb 27, 2022

vincentchabannes commented Jan 28, 2022 •

edited

vincentchabannes Feb 25, 2022 •

edited