Feature/pbdw #1786
Merged
Feature/pbdw #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
romainhild
commented
Feb 25, 2022
romainhild
commented
- Have you checked to ensure there aren't other open Pull Requests for the same change?
- Have you added an explanation of what your changes do and why you'd like us to include them?
- Have you written new tests for your changes?
- Have you successfully run the Feel++ testsuite with your changes locally?
- Have you written Doxygen comments in your contribution ?
- add PbdwOnline class without template for online phase of PBDW
- add possibility to use only some sensors during online phase
- add outputs to PBDW
- add outputs to toolboxmor
- add method to initialize toolboxmor directly with a toolbox
- add python wrapping for PBDW
- add test for PBDW
Before : return std::make_tuple(Mqm, Aqm, Fqm); Now : return std::make_tuple(Aqm, Fqm, Mqm); it will be compatible with python script not knowing if the problem il time-dpendant or not
the documentation is for now available in the report of internship (section 9.7) this code should be working. The time-dependant version will follow soon
/cc @prudhomm [ci skip]
WARNING : it is not finished yet, and the part written have not been tested yet with the pyfeelpp modules [ci skip]
[ci skip] (this modification was from a discussion a long time ago, I just forgot to commit it)
(not tested yet) this implementation won't word if the mass matrix depends on the parameter, but the python script reducedbasis takes that in account [ci skip]
(e37723c#commitcomment-59188226) [ci skip]
only working when M is independant of mu
[ci skip]
[ci skip]
still issues at execution
(independant of time) #1732
one test running greedy algotithm is long use pytest-3 -m "not long" to skip it
and complete doc
Co-authored-by: Christophe Prud'homme <christophe.prudhomme@feelpp.org> Co-authored-by: thomas-saigre <saigre@math.unistra.fr>
/TODO @thomas-saigre : add argument to pytest to give path toward cfg file
use this line to import the module in a script ``` from feelpp.mor.reducedbasis.reducedbasis import * ```
- assemble PETSc mat is they are not assembled yet - add more loop in Gram-Schmidt algo - fix call to reducedbasis module [ci skip]
added 17 commits
March 3, 2022 10:26
use support instead of all mesh for mass matrix
remove "without" methods use support of function space for riesz representative fix loadDB by resizing M_qs update python wrapping
it is there to keep a trace of how to do it
fix warning with CRBModel
@vincentchabannes do we still need the option use_velocity_convection ?
[ci skip]
|
@prudhomm @vincentchabannes I think this is ready to be merged. |
prudhomm
requested changes
Mar 8, 2022
|
@romainhild could you fix the little things above ? |
|
@romainhild empirical quadrature fails: https://buildkite.com/feelpp/feelpp/builds/4243#9edef1ff-364c-4938-b426-742839d1338b/759-815 |
|
@prudhomm this is a test with a random set of parameters, it seems that for this set we did not reach the tolerance (error: in "eq_suite/test_1": absolute value of i11 - i12{1.0829318330962678e-08} exceeds 1e-08). |
added 2 commits
March 14, 2022 09:04
skip feelpp skip toolboxes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.