Feature/importer samcef #1800
Merged
Feature/importer samcef #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vincentchabannes
commented
Mar 9, 2022
•
vincentchabannes
commented
- Have you checked to ensure there aren't other open Pull Requests for the same change?
- Have you added an explanation of what your changes do and why you'd like us to include them?
- Have you written new tests for your changes?
- Have you successfully run the Feel++ testsuite with your changes locally?
- Have you written Doxygen comments in your contribution ?
- Implement Samcef importer (only 3d currently)
- Implement Support multiple markers by entities #1795
prudhomm
approved these changes
Mar 9, 2022
There was a problem hiding this comment.
@vincentchabannes only minor improvements possible using universal ref, perfect forwarding and constexpr for readability,
super job!
| if ( verbose ) | ||
| cout << "[loadMesh] Loading mesh in format Samcef: " << fs::system_complete(mesh_name) << "\n"; | ||
| LOG(INFO) << " Loading mesh in Samcef format " << fs::system_complete(mesh_name); | ||
| CHECK( mesh ) << "Invalid mesh pointer to load " << mesh_name; |
There was a problem hiding this comment.
how about throwing an exception here ?
| this->addMarker( 1, v ); | ||
| } | ||
| template <typename TT,std::enable_if_t< is_iterable_of_v<TT,flag_type>, bool> = true > | ||
| void setMarker( TT const& vs ) |
There was a problem hiding this comment.
candidate for perfect forwarding ?
TT&&
| this->setMarker( 1, vs ); | ||
| } | ||
| template <typename TT,std::enable_if_t< is_iterable_of_v<TT,flag_type>, bool> = true > | ||
| void addMarker( TT const& vs ) |
| } | ||
| //! add flags vs to the marker type id k | ||
| template <typename TT,std::enable_if_t< is_iterable_of_v<TT,flag_type>, bool> = true > | ||
| void addMarker( uint16_type k, TT const& vs ) |
There was a problem hiding this comment.
candidate for constexpr and merge with the function above for greater readbility ?
|
and it is a little bit more than juste samcef reader ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.