-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add outputs for ToolboxMor and use CRBModels #1840
Conversation
the string "key" was used instead of the variable key
@thomas-saigre some changes here will impact you, you should check if everything is working for you. |
skip feelpp skip toolboxes
skip feelpp skip tests skip toolboxes
@prudhomm @vincentchabannes can you review the PR ? |
so if I understand well, we define parameters in the JSON by two ways :
Maybe I will have to modify some code in what I've done in feature/pyrb on fb7104a57a20e4b842367b193d2b5507afac5650 |
Probably yes, but there is a value field in CRBModelParameter, so you could use this for the default value. But there is no |
as long as there is an easy way to get the default values, I'm fine with it ! |
you can do for name, param in parameters:
print(param.value()) But you should also modify the json so that the value is in the CRBParameters section. |
mor/apps/toolboxmor_heat.cpp
Outdated
} | ||
} | ||
|
||
std::tuple<std::vector<double>,std::vector<double>,std::vector<double>,std::vector<double>> | ||
computeStats(std::vector<std::vector<double>> errs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const&
mor/apps/toolboxmor_heat.cpp
Outdated
return std::make_tuple(min, max, mean, stdev); | ||
} | ||
|
||
void writeStats(std::ostream& out, std::vector<double> min, std::vector<double> mean, std::vector<double> max, std::vector<double> stdev) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const& for vector args
{ | ||
if ( !M_p.contains(key) ) | ||
{ | ||
CHECK( false ) << "invalid key " << key; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw exception
auto const& j_key = M_p.at(key); | ||
if ( !j_key.is_string() ) | ||
{ | ||
CHECK( false ) << "key " << key << " not a string"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw exception
skip feelpp skip toolboxes skip tests
…into feature/toolboxmor-output
CRBParameters
which contains parameters with min and max valuesCRBOutputs
in the jsonmarkers
,topodim
, and optionalyexpr
coord
andradius
coord
expr
is dependant on the parameters.expr
should usecrb_u
,crb_grad_u_{0,1,2}
orcrb_dn_u
and the CRBParameters for the symbolsfeelpp_mor_heat
app on the field and outputsFor now, the outputs works only when using a scalar function space.