Fix/init parameter space #1894
Merged
Fix/init parameter space #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initalized with a constant space add corresponding test (with still an issue at this level) /cc @prudhomm @vincentchabannes see conversation on slack https://feelpp.slack.com/archives/C6A375EMS/p1653382504890379 skip feelpp skip tests skip tests skip toolboxes skip toolbox skip python
[ci skip]
/cc @vincentchabannes skip feelpp skip tests skip tests skip toolboxes skip toolbox skip python
[skip python, skip tests skip test]
check that an invalid interval is indeed spotted and that an error is returned [skip python]
vincentchabannes
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if we tried to initialize a
ParameterSpacewith no range of values in the sectionCRBParametersof the json, no error was raised, so it was be impossible to create a sampling with different parameters.These modifications ensure that at least one parameter can vary.
skip feelpp skip tests skip tests skip toolboxes skip toolbox skip python