1904 avoid using dofpoints compute them on the fly #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
prudhomm
commented
Jul 28, 2022
•
prudhomm
commented
- Have you checked to ensure there aren't other open Pull Requests for the same change?
- Have you added an explanation of what your changes do and why you'd like us to include them?
- Have you written new tests for your changes?
- Have you successfully run the Feel++ testsuite with your changes locally?
- Have you written Doxygen comments in your contribution ?
- closes Avoid using dofPoints, compute them on the fly #1904
…ofpoints-compute-them-on-the-fly
compute coordinates on the fly add geomap precompute and context computations for both elements and facets
lberti
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
It's better to wait for @vincentchabannes's confirmation before merging
vincentchabannes
approved these changes
Aug 24, 2022
vincentchabannes
deleted the
1904-avoid-using-dofpoints-compute-them-on-the-fly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.