Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrap createView #1925 #1926

Merged
merged 7 commits into from
Sep 6, 2022
Merged

wrap createView #1925 #1926

merged 7 commits into from
Sep 6, 2022

Conversation

prudhomm
Copy link
Member

skip feelpp skip toolboxes skip mor

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes?
  • Have you successfully run the Feel++ testsuite with your changes locally?
  • Have you written Doxygen comments in your contribution ?

@prudhomm
wrap createView #1925
20b75e3 
skip feelpp  skip toolboxes skip mor
@prudhomm prudhomm added this to the v110 milestone Aug 30, 2022
@prudhomm prudhomm self-assigned this Aug 30, 2022
@prudhomm prudhomm linked an issue Aug 30, 2022 that may be closed by this pull request
create function space element from PETSc vector in python #1925
Closed
prudhomm and others added 6 commits August 30, 2022 11:27
@prudhomm
add comment
1bc8bdd
@thomas-saigre
fix compilation and add a test for createFromPETSc
c09848e 
/cc @prudhomm @alielarif
[skip feelpp skip tests  skip toolboxes skip mor]
@prudhomm
add interface to creatre a VectorPETSc from a Vec
fb8852c 
two functions: one without datamap and one with.
Datamap is important if you have it. use the dof() member function of FunctionSpace class for example
you can also duplicate or not the memory storage, by default no duplication

/cc @thomas-saigre @alielarif
@prudhomm
build VectorPETSc first
14aae33 
/cc @thomas-saigre @alielarif
@thomas-saigre
tests: add new tests for conversion from Petsc.Vec to Vec
dd37ece 
/cc @prudhomm

[skip feelpp skip toolboxes skip mot skip tests]
@prudhomm
up create function space element from PETSc vector in python #1925
f8a6446 
add code + tests
However there is still an unrelated issue with mesh generation in parallel

/cc @thomas-saigre @alielarif
@vincentchabannes vincentchabannes merged commit 545c537 into develop Sep 6, 2022
@vincentchabannes vincentchabannes deleted the 1925-create-function-space-element-from-petsc-vector-in-python branch September 6, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentchabannes vincentchabannes vincentchabannes approved these changes

Assignees

@prudhomm prudhomm

Labels
component: pyfeelpp 🐍 module:python python support
Projects
Feel++
Status: Done
Milestone
v110
Development

Successfully merging this pull request may close these issues.

create function space element from PETSc vector in python
3 participants
@prudhomm @vincentchabannes @thomas-saigre