Use FindPkgConfig and petsc.pc instead of FindPETSc.cmake closes #1913 #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
prudhomm
commented
Sep 9, 2022
•
prudhomm
commented
- Have you checked to ensure there aren't other open Pull Requests for the same change?
- Have you added an explanation of what your changes do and why you'd like us to include them?
- Have you written new tests for your changes?
- Have you successfully run the Feel++ testsuite with your changes locally?
- Have you written Doxygen comments in your contribution ?
- closes Use FindPkgConfig and petsc.pc instead of FindPETSc.cmake #1913
- closes Port Feel++ to Fedora 36/37 #1914
prudhomm
added
env: cmake
Use FindPkgConfig and petsc.pc instead of FindPETSc.cmake #1913
|
to do still |
…tor and std::binary_function closes #1936
…dora #1934 - update pybind11 to latest release - add option to use system installation
closes #1934
update pybind11 to latest version to support python3.11 on Fedora #1934
Port Feel++ to Fedora 36/37 #1914
_1 not found need std::placeholder but use lambda instead for readbility Port Feel++ to Fedora 36/37 #1914
generate from cmake
…d-of-findpetsccmake
|
@vincentchabannes feel++ compiles on fedora:37 (I haven't tested yet on fedora:36), several compilation fixes have been made due to clang 14. |
Port Feel++ to Fedora 36/37 #1914
|
@vincentchabannes the PR builds fine. The remaining builds are due to changes to build fedora via github actions. The important build is this one: https://buildkite.com/feelpp/feelpp/builds/4655. |
…nfig-and-petscpc-instead-of-findpetsccmake
…d-of-findpetsccmake
…nfig-and-petscpc-instead-of-findpetsccmake [ci skip]
…d-of-findpetsccmake
|
the current build is here : https://buildkite.com/feelpp/feelpp/builds/4668 |
vincentchabannes
approved these changes
Oct 31, 2022
…nfig-and-petscpc-instead-of-findpetsccmake
prudhomm
deleted the
1913-use-findpkgconfig-and-petscpc-instead-of-findpetsccmake
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.