resolves 1949: support greedy procedure for nirb #1997

thomas-saigre · 2022-11-12T20:14:40Z

Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes?
Have you successfully run the Feel++ testsuite with your changes locally?
Have you written Doxygen comments in your contribution ?

Implementation of the greedy loop : #1949

Follow-up to #1927

(still issue in the criterion) - add option to init Coarse toolbox (useful for greedy function) - getReducedSolution : get the solution of coarse tolbox projected on basis made of coarse snapshots [ci skip]

Bumps [JamesIves/github-pages-deploy-action](https://github.com/JamesIves/github-pages-deploy-action) from 4.3.3 to 4.4.1. - [Release notes](https://github.com/JamesIves/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.3.3...v4.4.1) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…1949-greedy

use only 1 parameter to begin with [ci skip]

@alielarif

test_perf_nirb : - fix usage of class according to #1955 - allow to use greedy generation - add docstrings - save all files in a single directory, associated to the case (RESPATH) post_process.py : - refactor function plot_error so we can pass many directories of error to post process /cc @alielarif

… basis

- use of L2 scalar product in XH - normalize the scritrion [ci skip]

[ci skip]

@prudhomm

/cc @prudhomm #1924

[ci skip]

- for ramdom generation : add selection of random vector in a given set - for post process : add horizontal line for interpolation error

…1949-greedy

and adapt print to execution in parallel

seems more adaptated for vscode

- initProblem returns Xi_train - use makedirs instead of mkdir - fix execution of test_nirb

…1949-greedy

[skip feelpp, skip toolboxes, skip mor, skip tests]

[skip feelpp, skip tests, skip mor, skip toolboxes]

[ci skip]

[skip feelpp, skip toolboxes, skip tests, skip mor]

Fix typos in toolboxes subdir

…ves/github-pages-deploy-action-4.4.1 Bump JamesIves/github-pages-deploy-action from 4.3.3 to 4.4.1 [ci skip]

[ci skip]

@alielarif

…1949-greedy resolve conflicts /cc @alielarif

luzpaz and others added 30 commits September 30, 2022 09:29

Fix typos in toolboxes subdir

4a05b2a

Follow-up to #1927

start to work on greedy loop

9871186

up implementation of greedy loop

8e7cff7

(still issue in the criterion) - add option to init Coarse toolbox (useful for greedy function) - getReducedSolution : get the solution of coarse tolbox projected on basis made of coarse snapshots [ci skip]

fix: use mean of reduced solution

e921406

fix stop criterion #1949

792fda2

Merge branch 'develop' into typos/toolboxes

08b85a2

store Delta_star for each loop

cbec401

Merge remote-tracking branch 'origin/1912-implement-nirb-tools' into …

1dfddf8

…1949-greedy

fix configration of testcase :

3a69da9

use only 1 parameter to begin with [ci skip]

up: add step of orthonormalization of the coarse basis

4f62fe4

fix orthonormalization

cbe67b9

up: choose scalar product used to orthonormalize the coarse snapshots…

0ea1ebe

… basis

fix greedy algorithm:

165629f

- use of L2 scalar product in XH - normalize the scritrion [ci skip]

allow to use train sampling as test sampling #1949

2d73ae3

[ci skip]

fix recti fication in greedy loop #1949

b93a89e

[ci skip]

add wrapping for save / load a sampling into / from a file

0ef97db

/cc @prudhomm #1924

set the posibility to use a pre-generated train set in greedy #1949

30943ce

[ci skip]

add possibility to pass to initProblem a pre-loaded train set #1949

f59eb47

[ci skip]

up json #1949

90ea7f1

up :

eb9efe3

- for ramdom generation : add selection of random vector in a given set - for post process : add horizontal line for interpolation error

Merge remote-tracking branch 'origin/1912-implement-nirb-tools' into …

15a673b

…1949-greedy

fix execution of tests with greedy loop

4da6287

print infos [ci skip]

a7f392a

Merge branch '1949-greedy' of github.com:feelpp/feelpp into 1949-greedy

3ea56db

refactor : load Xi_train only once

af53a05

and adapt print to execution in parallel

doc: test new type of doctstring

6c8a308

seems more adaptated for vscode

refactor: remove duplicate of code

6c543ad

various fixes :

be8e08a

- initProblem returns Xi_train - use makedirs instead of mkdir - fix execution of test_nirb

thomas-saigre added 2 commits November 12, 2022 21:12

Merge remote-tracking branch 'origin/1912-implement-nirb-tools' into …

0160a40

…1949-greedy

fix test case and python warning

70588c5

thomas-saigre requested review from prudhomm and vincentchabannes as code owners November 12, 2022 20:14

fix tests #1949

00d5f4f

[skip feelpp, skip toolboxes, skip mor, skip tests]

thomas-saigre requested review from alielarif and removed request for vincentchabannes November 13, 2022 14:43

thomas-saigre added 2 commits November 14, 2022 16:43

refactor pre-compute coarse solution #1949

870121e

[skip feelpp, skip tests, skip mor, skip toolboxes]

change test name to facilitate usage of Ctest

e231d89

[ci skip]

alielarif approved these changes Nov 15, 2022

View reviewed changes

prudhomm and others added 16 commits November 15, 2022 16:37

Allow control log verbosity in python and c++ closes #1999

daf3e0e

no need for loadmesh, reduce dependencies

51dc87e

disable support for visibility on macos closes #1998

fe500c2

use lambda function to implement loadmesh

a51948a

fix failing test

9ceef91

[skip feelpp, skip toolboxes, skip tests, skip mor]

++verbose

cee9193

fix scheduled ci [ci skip]

0157da2

bump up to 111 [ci skip]

8ede084

Merge pull request #1965 from luzpaz/typos/toolboxes

772c611

Fix typos in toolboxes subdir

Merge pull request #1968 from feelpp/dependabot/github_actions/JamesI…

cd7f73e

…ves/github-pages-deploy-action-4.4.1 Bump JamesIves/github-pages-deploy-action from 4.3.3 to 4.4.1 [ci skip]

up to relaunch pipeline #1949

d9db54a

tiny fix in settings.json

7f26237

[ci skip]

Merge remote-tracking branch 'origin/1912-implement-nirb-tools' into …

1c8e9f6

…1949-greedy resolve conflicts /cc @alielarif

fix test_nirb_perf execution

cb8fa68

readd cln

889b074

Merge remote-tracking branch 'origin/develop' into 1949-greedy

5df7755

thomas-saigre merged commit 379da89 into 1912-implement-nirb-tools Nov 23, 2022

prudhomm changed the title ~~1949 greedy~~ resolves 1949: support greedy procedure for nirb Mar 18, 2024

prudhomm added the ✨ type:feature label Mar 18, 2024

prudhomm added this to the v111 milestone Mar 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resolves 1949: support greedy procedure for nirb #1997

resolves 1949: support greedy procedure for nirb #1997

thomas-saigre commented Nov 12, 2022

resolves 1949: support greedy procedure for nirb #1997

resolves 1949: support greedy procedure for nirb #1997

Conversation

thomas-saigre commented Nov 12, 2022