Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2026 reduced basis use hdf5 by default for saveload and allow basis loading in sequential #2030

Merged
merged 9 commits into from
Jan 31, 2023
Merged

2026 reduced basis use hdf5 by default for saveload and allow basis loading in sequential #2030

merged 9 commits into from
Jan 31, 2023

Conversation

lberti
Copy link
Collaborator

@lberti lberti commented Jan 17, 2023

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes?
  • Have you successfully run the mor testsuite with your changes locally?
  • Have you written Doxygen comments in your contribution ?

@lberti
Allow basis loading in sequential #2026
7502405 
- charge relation functionSpace for sequential online phase
@lberti
fix typo
cb84f0d
@lberti
Add option export-solution to crbonlinerun #2026
29cb04a 
- activates database and elements loading
@lberti
up command line documentation crbonlinerun #2026
a5b2e71
@lberti
#2026
f92d90a 
- change default format to HDF5
- save primal/dual basis functions to separate files
@lberti lberti linked an issue Jan 17, 2023 that may be closed by this pull request
Reduced basis: use HDF5 by default for save/load and allow basis loading in sequential #2026
Closed
2 tasks
vincentchabannes
vincentchabannes reviewed Jan 25, 2023
View reviewed changes
mor/apps/crbonlinerun.cpp Outdated Show resolved Hide resolved
mor/mor/feel/feelmor/crb.hpp Outdated Show resolved Hide resolved
mor/mor/feel/feelmor/crb.hpp Outdated Show resolved Hide resolved
mor/mor/feel/feelmor/crb.hpp Outdated Show resolved Hide resolved
mor/mor/feel/feelmor/crbdb.cpp Outdated Show resolved Hide resolved
@lberti
#2026
e795bef 
- fix boption with _name
- replace boost::format with fmt::format
@lberti
#2026
29ab227 
- revert lookForDB() function to its initial state
- delete saveNewRBelement and use save() function
@lberti
Merge branch 'develop' into 2026-reduced-basis-use-hdf5-by-default-fo…
ace9a8e 
…r-saveload-and-allow-basis-loading-in-sequential
@lberti
Copy link
Collaborator Author

lberti commented Jan 30, 2023

@vincentchabannes, the checks have passed. The last changes might have to be reviewed and, if everything is ok, this PR could be merged

@vincentchabannes
Merge branch 'develop' into 2026-reduced-basis-use-hdf5-by-default-fo…
0283e43 
…r-saveload-and-allow-basis-loading-in-sequential
@vincentchabannes vincentchabannes merged commit 36b024a into develop Jan 31, 2023
@vincentchabannes vincentchabannes deleted the 2026-reduced-basis-use-hdf5-by-default-for-saveload-and-allow-basis-loading-in-sequential branch January 31, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentchabannes vincentchabannes vincentchabannes approved these changes

@prudhomm prudhomm Awaiting requested review from prudhomm prudhomm is a code owner

Assignees
No one assigned
Labels
✨ type:feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduced basis: use HDF5 by default for save/load and allow basis loading in sequential
3 participants
@lberti @vincentchabannes @prudhomm