-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves 2014: add-multiblock-2d-and-3d-use-case-generator #2035
Merged
prudhomm
merged 21 commits into
develop
from
2014-add-multiblock-2d-and-3d-use-case-generator
Feb 18, 2023
Merged
resolves 2014: add-multiblock-2d-and-3d-use-case-generator #2035
prudhomm
merged 21 commits into
develop
from
2014-add-multiblock-2d-and-3d-use-case-generator
Feb 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(only works when Nd = 1)
… use case generator #2014
…thub.com:feelpp/feelpp into 2014-add-multiblock-2d-and-3d-use-case-generator
thomas-saigre
requested review from
prudhomm and
vincentchabannes
as code owners
January 24, 2023 09:01
prudhomm
changed the title
2014-add-multiblock-2d-and-3d-use-case-generator
resolves 2014: add-multiblock-2d-and-3d-use-case-generator
Jan 24, 2023
prudhomm
approved these changes
Jan 24, 2023
* stem:[L] is the length of it, | ||
* stem:[h] is the height of it, | ||
* stem:[d] is the depth | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide an example here ? or several
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 7a176cd.
I also updated the branch with develop
to check that it is not in conflict with it.
[ci skip]
…k-2d-and-3d-use-case-generator [ci skip]
[ci skip]
… tests skip toolboxes skip mor
…dd multiblock 2D and 3D use case generator #2014
prudhomm
deleted the
2014-add-multiblock-2d-and-3d-use-case-generator
branch
February 18, 2023 10:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @prudhomm @alielarif
no change has been made to the core of feelpp, only python script to generate the testcase described in #2014
The case works in both 2d and 3d, and we can set the dimension of the blocks, as well as the numebr of them ($n_\text{row}$ and $n_\text{cols}$ , named
Nv
andNh
resp. in the code)[ci skip]