Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves 2014: add-multiblock-2d-and-3d-use-case-generator #2035

Merged
merged 21 commits into from
Feb 18, 2023

Conversation

thomas-saigre
Copy link
Contributor

@thomas-saigre thomas-saigre commented Jan 24, 2023

/cc @prudhomm @alielarif

no change has been made to the core of feelpp, only python script to generate the testcase described in #2014

The case works in both 2d and 3d, and we can set the dimension of the blocks, as well as the numebr of them ($n_\text{row}$ and $n_\text{cols}$, named Nv and Nh resp. in the code)

[ci skip]

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes?
  • Have you successfully run the Feel++ testsuite with your changes locally?
  • Have you written Doxygen comments in your contribution ?

@thomas-saigre thomas-saigre linked an issue Jan 24, 2023 that may be closed by this pull request
@prudhomm prudhomm changed the title 2014-add-multiblock-2d-and-3d-use-case-generator resolves 2014: add-multiblock-2d-and-3d-use-case-generator Jan 24, 2023
* stem:[L] is the length of it,
* stem:[h] is the height of it,
* stem:[d] is the depth

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide an example here ? or several

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 7a176cd.
I also updated the branch with develop to check that it is not in conflict with it.

@prudhomm prudhomm merged commit e06fce0 into develop Feb 18, 2023
@prudhomm prudhomm deleted the 2014-add-multiblock-2d-and-3d-use-case-generator branch February 18, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🏭 add multiblock 2D and 3D use case generator
3 participants