Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves 2103, 2099: update Model Meshes and fix expression symbol missing in Toolboxes #2100

Merged
merged 7 commits into from
May 27, 2023
Merged

resolves 2103, 2099: update Model Meshes and fix expression symbol missing in Toolboxes #2100

merged 7 commits into from
May 27, 2023

Conversation

vincentchabannes
Copy link
Member

@vincentchabannes vincentchabannes commented May 25, 2023 •
edited by prudhomm

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes?
  • Have you successfully run the Feel++ testsuite with your changes locally?
  • Have you written Doxygen comments in your contribution ?

update ModelMeshes :

update Toolboxes:

@vincentchabannes vincentchabannes self-assigned this May 25, 2023
prudhomm
prudhomm approved these changes May 27, 2023
View reviewed changes
toolboxes/tests/coefficientformpdes/test_coefficientformpdes.cpp
cfpdes->exportResults();


// TODO compute measures and check results!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you plan to do that in the PR or another one ?

@prudhomm prudhomm changed the title Feature/toolboxes toolboxes modelmeshes resolves 2103, 2099: update Model Meshes and fix expression symbol missing in Toolboxes May 27, 2023
@prudhomm prudhomm self-assigned this May 27, 2023
@prudhomm prudhomm merged commit d23bc9a into develop May 27, 2023
1 check passed
@prudhomm prudhomm deleted the feature/toolboxes_toolboxes_modelmeshes branch May 27, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prudhomm prudhomm prudhomm approved these changes

Assignees

@prudhomm prudhomm

@vincentchabannes vincentchabannes

Labels
✨ type:feature 🧰 component: toolboxes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve ModelMeshes Missing Physics/Meshes Symbols Expr with various Toolboxes
2 participants
@vincentchabannes @prudhomm