resolves 2143: clean mor #2146
Merged
resolves 2143: clean mor #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add clearer exception messages - add interface to control configuration re-enable and fix mor testcases #2144 skip feelpp skip tests skip toolboxes
Closed
5 tasks
prudhomm
changed the title
vincentchabannes
approved these changes
Jul 17, 2023
- simplify use of onlinerun - make it work for time series outputs
the erro bound now should be correct, there was a bug in the computation. skip feelpp skip tests skip toolboxes
skip feelpp skip tests skip toolboxes
- Added a new struct MORObserver to the codebase for observing the models - Added a new struct MORModels to represent a list of models for a given problem - Added a new class MORTable for storing and displaying results in a table format - Added a new class MORExporter for exporting results to files - Updated the run() function in MORModels to accept a sampling parameter - Updated the initExporter() and saveExporter() functions in MORModels to use the first model exporter for all exports if load==all - Updated the update() function in the MORExporter class to export fields for all models - Updated the update() function in the MORTable class to populate the table with results for all models - Updated the run() function in MORModels to generate and return results for all models and output configurations skip feelpp skip tests skip toolboxes
add support for mor_python that will enable in cmake the mor and python components only (of course feelpp and toolboxes need to be already installed on the system) /cc @thomas-saigre @lberti @Hassan-Ballout21 skip feelpp skip tests skip toolboxes
add notebook to test it out
set FEELPP_MOR_FOUND to true if in mor+python case
minor fixes
worked on a new architecture for the mor db that would have both the db the plugin and some metadata that would allow to gather all outputs of a given model skip feelpp skip tests skip toolboxes
now a MORModels can be created from - a path to the directory containing the json file binaries and db - a .fpp file (zip archive) that will provide the same previous information (json + binaries + db) /cc @thomas-saigre @Hassan-Ballout21 @lberti skip feelpp skip tests skip toolboxes
- clean mor #2143 and improve ParameterSpace classes Element and Sampling skip feelpp skip tests skip toolboxes
clean mor #2143 skip feelpp skip tests skip toolboxes
skip feelpp skip tests skip toolboxes
use more explicit/informative exceptions clean mor #2143 skip feelpp skip tests skip toolboxes
vincentchabannes
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip feelpp skip tests skip toolboxes