fix toc display for crb code #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure that no mor than 15 columns are set in toc call - do not display online time results in log, while still measuring time (available in display-stats) /cc @prudhomm
thomas-saigre
requested review from
prudhomm and
vincentchabannes
as code owners
prudhomm
requested changes
Oct 10, 2023
There was a problem hiding this comment.
@thomas-saigre we don't want to have LOG(INFO) in the online code (imagine thousands of computation, it would generate a huge log), so lets use VLOG(3) and get the toc value outside the VLOG/LOG
/cc @prudhomm [skip feelpp, skip tests, skip toolboxes, skip python]
prudhomm
approved these changes
Oct 10, 2023
/cc @prudhomm [skip feelpp, skip tests, skip toolboxes, skip python]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(available in display-stats)
/cc @prudhomm