Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves 2182: Enable specx in CMakeLists.txt #2183

Merged
merged 5 commits into from
Nov 14, 2023
Merged

resolves 2182: Enable specx in CMakeLists.txt #2183

merged 5 commits into from
Nov 14, 2023

Conversation

prudhomm
Copy link
Member

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes?
  • Have you successfully run the Feel++ testsuite with your changes locally?
  • Have you written Doxygen comments in your contribution ?

@prudhomm prudhomm linked an issue Nov 13, 2023 that may be closed by this pull request
Enable specx support by default #2182
Closed
@prudhomm prudhomm self-assigned this Nov 13, 2023
@prudhomm
Copy link
Member Author

@berenger-eu @lemoinep @vincentchabannes I enable specx by default in feelpp. This will ease using specx in projects using feelpp like feelpp/solar-shading

@prudhomm
Copy link
Member Author

this requires however that packaging is updated to support specx

@prudhomm
Copy link
Member Author

@vincentchabannes the PR is ready. Update Branch is not necessary here

@vincentchabannes vincentchabannes merged commit 6a3a2ba into develop Nov 14, 2023
13 checks passed
@vincentchabannes vincentchabannes deleted the 2182-enable-specx-support-by-default branch November 14, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentchabannes vincentchabannes vincentchabannes approved these changes

Assignees

@prudhomm prudhomm

Labels
🏃 runtime: specx specx runtime ✨ type:feature
Projects
Feel++
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable specx support by default
2 participants
@prudhomm @vincentchabannes