resolves 2205: add support for ubuntu 2404 #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
prudhomm
commented
Dec 29, 2023
•
prudhomm
commented
- Have you checked to ensure there aren't other open Pull Requests for the same change?
- Have you added an explanation of what your changes do and why you'd like us to include them?
- Have you written new tests for your changes?
- Have you successfully run the Feel++ testsuite with your changes locally?
- Have you written Doxygen comments in your contribution ?
- closes add support for c++20 #2206
- closes add support for boost 1.83 #2204
- closes add support for ubuntu 24.04 #2205
- closes support pointwise sensor in case of vectorial fields and add magnitude #2214
- closes compiling cln in debug mode #2220
- closes support export mesh by parts #2221
- closes export pid in mesh_exporter application #2222
|
here is the ctest status with clang c++20 boost 1.83 and ubuntu 24.04 the python tests failed, probably a problem with python installation or configuration in the docker image |
= is not needed add support for c++20 #2206
- try fix linking issue with LDLAGS - add export compile command for vscode - add ctest preset
|
here is the status of the testsuite on 24.04 and boost 1.83: |
with docker we can use different distribution and architectures use DISTRIBUTION and ARCH to make the build explicity eg DISTRIBUTION="-jammy" DISTRIBUTION="-focal" ARCH="-aarch64" prepend "-" to make the build dir more readable if these env var are not defined then it is just as before
use HDF5_LINK_LIBRARIES
|
those tests are currently failing: |
| @@ -39,10 +39,11 @@ struct MeshContiguousNumberingMapping | |||
| using range_element_type = elements_reference_wrapper_t<mesh_type>; | |||
| using point_ref_type = boost::reference_wrapper< typename mesh_type::point_type const>; | |||
|
|
|||
| explicit MeshContiguousNumberingMapping( mesh_type* mesh, bool interprocessPointAreDuplicated = false ) | |||
| explicit MeshContiguousNumberingMapping( mesh_type* mesh, bool interprocessPointAreDuplicated = false, bool exportByParts = true ) | |||
There was a problem hiding this comment.
@prudhomm The idea was to put a struct here (not just a boolean), with possibility to define a more complex behavior.
For example, A part name toto will contain a range of elements, another part named titi with another range, …
This is required for our kub application.
For a simpler use, A JSON object and a mesh can set up easily this struct.
There was a problem hiding this comment.
is it possible to do that in another specific branch/PR ? I guess there would be more development than that.
this will unbreak the exports
There was a problem hiding this comment.
Yes, I understand. I only thought of adding the struct with a boolean and init from a Mesh. This will avoid breaking the API in the future.
There was a problem hiding this comment.
ok I can do that, what do you want as an API ?
just replace the bool by a json ?
There was a problem hiding this comment.
No, a c++ struct or class with inside a mesh pointer and this boolean for now.
The JSON will be used to build this object (another constructor), but it can be done in the future.
In kub app, I will add directly the range in this struct.
…ssian_sensor [skip toolboxes, skip python, skip mor]
skip feelpp
skip feelpp
…/feelpp/feelpp into 2205-add-support-for-ubuntu-2404
added completion for bash [ci skip]
skip feelpp skip testsuite
skip feelpp skip testsuite
[ci skip] /cc @prudhomm
…or-ubuntu-2404 [ci skip]
see https://bugs.launchpad.net/ubuntu/+source/gmsh/+bug/2056625 for more details this should fix the last issue in toolboxes skip testsuite
reduce default verbosity of gmsh
skip feelpp skip testsuite
fix compilation on 24.04 (deprecated boost header) skip feelpp skip testsuite skip toolboxes
needed to increase remesh frequency @VLCeline otherwise I get a crash on 24.04 skip feelpp skip testsuite skip toolboxes skip mor
|
@vincentchabannes the PR is now ready , it compiles on debian:12 ubuntu:22.04 and ubuntu:24.04 |
vincentchabannes
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.