Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert git commit patch #796

Closed
akgrant43 opened this issue Jan 30, 2020 · 4 comments
Closed

Revert git commit patch #796

akgrant43 opened this issue Jan 30, 2020 · 4 comments

Comments

@akgrant43
Copy link
Contributor

Revert feenkcom/tffi-dev@2f8c30e once pharo-vcs/libgit2-pharo-bindings#32 has been applied upstream.
@akgrant43
Copy link
Contributor Author

Status 24 Feb 2020

Pharo 9 currently loads libgit2-pharo-bindings tag v1.5.8. Since this was tagged a number of commits have been made, in particular pharo-vcs/libgit2-pharo-bindings@89431c7.

The result is that pharo-vcs/libgit2-pharo-bindings#32 no longer merges cleanly. However it also isn't possible to load the master branch in to a Pharo 9 image (I haven't looked, but presumably libgit is used mid-change, and breaks).

Either I have to track down the issues between v1.5.8 and master, probably by bootstrapping a Pharo 9 image that loads master directly, or wait for it to get to a more stable state.

I'm currently waiting...

@girba
Copy link
Member

girba commented Aug 9, 2020

Is this still open?

@akgrant43
Copy link
Contributor Author

This is fixed in Pharo 9, so can be reverted as part of our move to Pharo 9.

@akgrant43
Copy link
Contributor Author

Alex upgraded us to Pharo 9 and removed the need for tffi-dev, so this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@girba @akgrant43