Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading files directly #19

Merged
merged 3 commits into from Jan 25, 2021
Merged

Loading files directly #19

merged 3 commits into from Jan 25, 2021

Conversation

fekad
Copy link
Owner

@fekad fekad commented Jan 19, 2021

Following the suggestion in #17 the load_file and from_file methods uses inline=False default value.

@markperri
Copy link

Thanks, looks good!
Mark

@fekad fekad mentioned this pull request Jan 25, 2021
Closed
@fekad fekad merged commit 900293b into master Jan 25, 2021
@fekad fekad deleted the inline_default_value branch March 11, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fekad @markperri