fix(flutter_bloc): Add dependency to bloc instance for BlocBuilder/BlocListener/BlocConsumer #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr0gramista
changed the title
felangel
added
bug
Codecov Report
@@ Coverage Diff @@
## master #2482 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 118 139 +21
=========================================
+ Hits 118 139 +21
Continue to review full report at Codecov.
|
|
@felangel seems like |
felangel
reviewed
May 27, 2021
| @@ -145,6 +155,7 @@ class _BlocBuilderBaseState<B extends BlocBase<S>, S> | |||
|
|
|||
| @override | |||
| Widget build(BuildContext context) { | |||
| if (widget.bloc == null) context.select<B, int>(identityHashCode); | |||
There was a problem hiding this comment.
It's a very creative idea to solve the previous issue! I made one minor adjustment to use identityHashCode in case developers override hashCode manually.
felangel
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
Fixes #2127
Closes #2181
To make a builder, listener or consumer update when the instance is changed we need a context dependency. However we can't use normal
context.watchbecause BlocProvider uses a custom provider which also updates dependents when state is changed, therefore it would makebuildWhenuseless. Ideally we would reverse that, but that would also break compatibility. Adding another "normal" provider is also not an option since provider does not allow it and integrating special InheritedWidget is tricky.There is a concept of "aspect" when it comes to dependencies. Provider exposes it by
context.select, but it is a bit different and it can't be used indidUpdateDependencies, but we can put it in build and use it to target only the changes of the instance by retrieving hashCode.I think for people who doesn't change instances in the runtime this makes almost no difference apart from dependency.
Type of Change