Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bloc)!: add throws StateError when bloc is closed #2912

Merged
merged 2 commits into from
Oct 30, 2021
Merged

feat(bloc)!: add throws StateError when bloc is closed #2912

merged 2 commits into from
Oct 30, 2021

Conversation

felangel
Copy link
Owner

Status

READY

Breaking Changes

YES

Description

  • feat(bloc)!: add throws StateError when bloc is closed

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added enhancement New feature or request release candidate Candidate for release pending successful build pkg:bloc This issue is related to the bloc package breaking change Enhancement candidate would introduce a breaking change labels Oct 30, 2021
@felangel felangel self-assigned this Oct 30, 2021
@felangel felangel added this to In progress in bloc via automation Oct 30, 2021
@codecov
Copy link

codecov bot commented Oct 30, 2021 •
edited
Loading

Codecov Report

Merging #2912 (4ca10d8) into feat/v8.0.0 (0367074) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           feat/v8.0.0     #2912    +/-   ##
==============================================
  Coverage       100.00%   100.00%            
==============================================
  Files               25         3    -22     
  Lines              638       164   -474     
==============================================
- Hits               638       164   -474
Impacted Files Coverage Δ
packages/bloc/lib/src/bloc.dart 100.00% <ø> (ø)
packages/bloc_concurrency/lib/src/restartable.dart
packages/replay_bloc/lib/src/replay_bloc.dart
...ages/flutter_bloc/lib/src/multi_bloc_provider.dart
packages/hydrated_bloc/lib/src/hydrated_bloc.dart
packages/bloc_concurrency/lib/src/concurrent.dart
packages/bloc_test/lib/src/when_listen.dart
packages/bloc_concurrency/lib/src/droppable.dart
...lutter_bloc/lib/src/multi_repository_provider.dart
...ages/flutter_bloc/lib/src/repository_provider.dart
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0367074...4ca10d8. Read the comment docs.

@felangel felangel added this to the v8.0.0 milestone Oct 30, 2021
@felangel felangel force-pushed the feat/bloc-add-throws-when-closed branch from 50c6d66 to 5b8e33b Compare October 30, 2021 23:29
@felangel felangel force-pushed the feat/bloc-add-throws-when-closed branch from 96e1858 to 4ca10d8 Compare October 30, 2021 23:37
@felangel felangel merged commit 237ecb5 into feat/v8.0.0 Oct 30, 2021
bloc automation moved this from In progress to Done Oct 30, 2021
@felangel felangel deleted the feat/bloc-add-throws-when-closed branch October 30, 2021 23:39
felangel added a commit that referenced this pull request Nov 3, 2021
@felangel
feat(bloc)!: add throws StateError when bloc is closed (#2912)
3d12819
felangel added a commit that referenced this pull request Nov 8, 2021
@felangel
feat(bloc)!: add throws StateError when bloc is closed (#2912)
d4a49e5
felangel added a commit that referenced this pull request Nov 17, 2021
@felangel
feat(bloc)!: add throws StateError when bloc is closed (#2912)
afd235c
@felangel felangel mentioned this pull request Nov 17, 2021
Merged
7 tasks
felangel added a commit that referenced this pull request Nov 18, 2021
@felangel
feat(bloc)!: add throws StateError when bloc is closed (#2912)
ecb0e00
@DenisBogatirov DenisBogatirov mentioned this pull request Nov 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@felangel felangel

Labels
breaking change Enhancement candidate would introduce a breaking change enhancement New feature or request pkg:bloc This issue is related to the bloc package release candidate Candidate for release pending successful build
Projects
bloc
  
Done
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@felangel