-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(flutter_bloc): BlocListener, BlocProvider missing child assertion #2924
fix(flutter_bloc): BlocListener, BlocProvider missing child assertion #2924
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor styling comments. Other than that; ππ»
tester.takeException(), | ||
isA<AssertionError>().having((e) => e.message, 'message', expected), | ||
); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}); | |
}, | |
); |
and format
Same goes for other tests, though I'm not sure what you're styling convention is here so feel free to ignore! π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For internal consistency I prefer to leave the test format as is but thanks for the review, really appreciate it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM π
Status
READY
Breaking Changes
NO
Description
Type of Change