Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flutter_bloc): BlocListener, BlocProvider missing child assertion #2924

Merged
merged 2 commits into from
Nov 7, 2021

Conversation

felangel
Copy link
Owner

@felangel felangel commented Nov 5, 2021

Status

READY

Breaking Changes

NO

Description

  • fix(flutter_bloc): BlocListener, BlocProvider missing child assertion

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ› οΈ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • βœ… Build configuration change
  • πŸ“ Documentation
  • πŸ—‘οΈ Chore

@felangel felangel added bug Something isn't working pkg:flutter_bloc This issue is related to the flutter_bloc package labels Nov 5, 2021
@felangel felangel self-assigned this Nov 5, 2021
@felangel felangel added this to In progress in bloc via automation Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #2924 (c4f39a6) into master (22e13c5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #2924    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           25         9    -16     
  Lines          720       176   -544     
==========================================
- Hits           720       176   -544     
Impacted Files Coverage Ξ”
packages/flutter_bloc/lib/src/bloc_listener.dart 100.00% <100.00%> (ΓΈ)
packages/flutter_bloc/lib/src/bloc_provider.dart 100.00% <100.00%> (ΓΈ)
packages/replay_bloc/lib/src/change_stack.dart
packages/bloc_test/lib/src/when_listen.dart
packages/bloc_concurrency/lib/src/droppable.dart
packages/bloc_test/lib/src/bloc_test.dart
...ackages/hydrated_bloc/lib/src/hydrated_cipher.dart
packages/replay_bloc/lib/src/replay_bloc.dart
packages/bloc/lib/src/transition.dart
...ckages/hydrated_bloc/lib/src/hydrated_storage.dart
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 22e13c5...c4f39a6. Read the comment docs.

Copy link
Collaborator

@jeroen-meijer jeroen-meijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor styling comments. Other than that; πŸ‘ŒπŸ» :shipit:

tester.takeException(),
isA<AssertionError>().having((e) => e.message, 'message', expected),
);
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
});
},
);

and format

Same goes for other tests, though I'm not sure what you're styling convention is here so feel free to ignore! πŸ˜„

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For internal consistency I prefer to leave the test format as is but thanks for the review, really appreciate it!

Copy link
Collaborator

@marcossevilla marcossevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸš€

@felangel felangel merged commit cd62ecc into master Nov 7, 2021
@felangel felangel deleted the fix/bloc-listener/provider-missing-child-assertion branch November 7, 2021 03:09
bloc automation moved this from In progress to Done Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:flutter_bloc This issue is related to the flutter_bloc package
Projects
bloc
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants